- Issue created by @Rajab Natshah
- 🇨🇭Switzerland saschaeggi Zurich
Might this be related to your problem 🐛 Fix Custom wide or square logo in toolbar floated on left Fixed ?
- 🇯🇴Jordan Rajab Natshah Jordan
Thanks, Sascha for the hint, and landing on this issue!!
Next time, I Gin first.
Having
padding: var(--gin-spacing-xs) var(--gin-spacing-s)
fixed the issue in my case.toolbar .toolbar-bar #toolbar-item-administration-tray .toolbar-logo { padding: var(--gin-spacing-xs) var(--gin-spacing-s) !important; }
I will have a Patch/MR in 🐛 Fix Custom wide or square logo in toolbar floated on left Fixed
Trying to do the following. But it's not loading.
libraries-extend: gin/gin_toolbar: - vartheme_claro/toolbar gin/gin_horizontal_toolbar: - vartheme_claro/toolbar gin/gin_classic_toolbar: - vartheme_claro/toolbar
Feels that the fix in Gin will be better
as you do haveif ($toolbar === 'classic') { // Attach the classic toolbar styles. $page['#attached']['library'][] = 'gin/gin_classic_toolbar'; } elseif ($toolbar === 'horizontal') { // Attach the horizontal toolbar styles. $page['#attached']['library'][] = 'gin/gin_horizontal_toolbar'; } else { // Attach toolbar styles. $page['#attached']['library'][] = 'gin/gin_toolbar'; }
- 🇯🇴Jordan Rajab Natshah Jordan
Got it, it's in layouts not in components.
https://git.drupalcode.org/project/gin/-/merge_requests/252/diffs -
Rajab Natshah →
committed 1fe66106 on 4.0.x
Issue #3357580: Fix Varbase logo in Gin Toolbar after Admin Toolbar 3.3....
-
Rajab Natshah →
committed 1fe66106 on 4.0.x
- 🇯🇴Jordan Rajab Natshah Jordan
Had the fix in 🐛 Fix Custom wide or square logo in toolbar floated on left Fixed
using the current patch to fix for Sidebar, Vertical Toolbar (Default) -
Rajab Natshah →
committed b93abb41 on 4.0.x
Issue #3357580: Fix Varbase logo in Gin Toolbar after Admin Toolbar 3.3....
-
Rajab Natshah →
committed b93abb41 on 4.0.x
-
Rajab Natshah →
committed 51b2cc44 on 4.0.x
Issue #3357580: Fix Varbase logo in Gin Toolbar after Admin Toolbar 3.3....
-
Rajab Natshah →
committed 51b2cc44 on 4.0.x
- Assigned to Mohammed J. Razem
- Status changed to Needs review
over 1 year ago 1:41pm 3 May 2023 - Issue was unassigned.
- Status changed to Fixed
over 1 year ago 1:41pm 3 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 3:17pm 25 May 2023