- Issue created by @alexandersluiter
- @alexandersluiter opened merge request.
- πΊπΈUnited States alexandersluiter
This issue can be closed. I have failed to handle this with an MR via Composer. Steps to handle this "manually":
- Place the empty shim module in my own repository under the custom modules directory. This will be removed in my own applications next minor release.
- Remove Commerce Google Tag Manager completely via composer.
- Uninstall Commerce Google Tag Manager.
- Upgrade Google Tag Manager to 2.x via Composer
- Profit.
- π¦πΉAustria agoradesign
So, commerce_google_tag_manager is no longer needed, when upgrading google_tag to 2.x, right? or is there any extra functionality currently in this module, that is missing in google_tag v2?
regarding your comment - why would you need the empty shim? why not just unistall the module, then upgrade google_tag?
- π¬π·Greece giorgosk Chios, Greece π¬π·
@agoradesign I think the google_tag implementation is missing a few triggers with the most important one "purchase" missing
https://git.drupalcode.org/project/google_tag/-/tree/2.0.x/src/EventSubs... - π¦πΉAustria agoradesign
Are you sure? Have a look at this one: https://git.drupalcode.org/project/google_tag/-/blob/2.0.x/src/EventSubs...
- Status changed to Needs review
9 months ago 4:40pm 19 February 2024 - Status changed to Needs work
9 months ago 4:53pm 19 February 2024 - πΊπΈUnited States rszrama
If I may expand the scope of this issue just a bit ... I actually think this module should be deprecated, and we should recommend everyone move over to Google Tag. Aside from having much greater adoption and development support, it's also already doing most of what this module was previously doing.
Given Google Tag already supports most features of this module, I think we should:
- Identify any remaining gaps via issues in that module's queue.
- Work with the maintainers to get them incorporated into a release.
- Provide documentation for folks to follow to migrate their configuration or custom code to the new module.
I began this by tagging a couple of issues with "Deprecate Commerce GTM" related to using placed vs. paid for the purchase event and expanding support for checkout tracking. If there are any other gaps, can we get them in issues using the same tag?
https://www.drupal.org/project/issues/search?issue_tags=Deprecate%20Comm... β
- π¨πSwitzerland wengerk Lausanne
Many thanks to everyone who has been following the changes and development of Google Tag 2.x.
I will quickly tag this module as deprecated and link it to Google Tag 2.x as a replacement.
Additionally, I will direct users to this issue thread.Here is the text that will appear on the project page. Do you have any suggestions or changes before publishing it, later today ?!
Commerce Google Tag Manager has been deprecated and recommends transitioning to the Google Tag β module, up to release 2.x, as a direct replacement.
Originally developed as a straightforward integration for Commerce applications, Google Tag β now fully supports most features of this module, rendering it unnecessary.
For a comprehensive report on backported features and any missing functionalities, please refer to issue #3357144 β¨ Support Google Tag 2.x Module Active . - πΊπΈUnited States rszrama
Should we try to close the gaps first? Will marking it deprecated generate warnings or anything in the Drupal back-end for module users?
- π¨πSwitzerland berdir Switzerland
The module was already deprecated from two ends, it wasn't Drupal 10 compatible and it only supported the old commerce analytics API.
- leymannx Berlin
Yes, you get the below red warning on /admin/reports/updates and probably also in the mails.
Project not supported: This project is no longer supported, and is no longer available for download. Disabling everything included by this project is strongly recommended!
Would have been good to close the gaps first and give users an upgrade path. Now we need to figure out on our own. Will need to allocate time for it and try to document what needs to be done manually on top.
- leymannx Berlin
Ah yeah, it even triggers this message in all of the backend:
Error message
One or more problems were detected with your Drupal installation. Check the status report for more information.