- Issue created by @Harish1688
- Status changed to Needs review
almost 2 years ago 6:43am 2 May 2023 - 🇮🇳India Harish1688 India
created a patch 'space-between-search-field-close-icon-3357108-4.patch' needs review.
core v : 10.1.x and Olivero v : 8.x-1.x-dev
attached screen after patch. - Assigned to atul_ghate
- 🇮🇳India Akshay kashyap
Hi @Harish1688,
Thanks for the work.
Verified and tested Patch Comment #4 on Drupal 10.1.x Applied patch cleanly
git apply -v space-between-search-field-close-icon-3357108-4.patch Checking patch core/themes/olivero/css/components/header-search-wide.css... Checking patch core/themes/olivero/css/components/header-search-wide.pcss.css... Applied patch core/themes/olivero/css/components/header-search-wide.css cleanly. Applied patch core/themes/olivero/css/components/header-search-wide.pcss.css cleanly.
Testing Steps:-
1. Install Drupal 10.1.x version.
2. Enable the Olivero theme and set the theme
3. click on the search icon on the top menu
5. Observe that Need space between the search field and its close icon.
6. Apply the patch.
7. Checked the changes difference using git diff
8. Observe the space is there between the search field and its close icon.Testing Result:
1. The space is there between the search field and its close icon after applying the patch. Screenshots are attached for reference: - Status changed to RTBC
almost 2 years ago 7:06am 2 May 2023 - Issue was unassigned.