- Issue created by @dineshkumarbollu
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:08am 27 April 2023 - 🇮🇳India dineshkumarbollu
Hi
i fixed all the phpcs Issues except below error because it is not a hook to fix the issue.
--------------------------
228 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "_context_option_list" but expected "layout_builder_context__context_option_list"
-please Review
- Status changed to RTBC
over 1 year ago 7:37am 27 April 2023 - 🇵🇭Philippines paraderojether
Hi dineshkumarbollu,
I reviewed patch #2 and confirmed it fixes the issue reported by phpcs except for issue that you mentioned. Drupal core 9.5.8, Layout Builder Context Integration 1.0.x-dev.
I added screenshots for reference.
Thank You - 🇺🇸United States kevinquillen
Its supposed to be a private function, not a hook, only callable by functions in that file.
-
kevinquillen →
committed 0daea2c4 on 1.0.x
Issue #3356787 by kevinquillen: Fix the issues reported by phpcs
-
kevinquillen →
committed 0daea2c4 on 1.0.x
- Status changed to Fixed
over 1 year ago 12:47pm 27 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.