- Issue created by @himanshu_jhaloya
- @himanshu_jhaloya opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 12:31pm 26 April 2023 - Status changed to RTBC
almost 2 years ago 3:26pm 16 May 2023 - 🇵🇭Philippines kenyoOwen
Hi himanshu_jhaloya
I applied your MR to the “Axeptio” module and confirmed that the Dependency injection issue mentioned is resolved. Please see the screenshots attached.
For your review.
Thank you. - Status changed to Needs work
almost 2 years ago 5:13pm 16 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ /** + * Language Manager service. + * + * @var \Drupal\Core\Language\LanguageManagerInterface + */ + protected $languageManager; ++ * @param \Drupal\Core\Language\LanguageManagerInterface $languageManager + * Language Manager service.The description is missing a definite article.
Only the first word must be capitalized.
It is not necessary to say service. - First commit to issue fork.
- Status changed to Needs review
almost 2 years ago 6:23pm 16 May 2023 - Status changed to Needs work
almost 2 years ago 7:56pm 16 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ /** + * Language manager service. + * + * @var \Drupal\Core\Language\LanguageManagerInterface + */ + protected $languageManager;+ * @param \Drupal\Core\Language\LanguageManagerInterface $languageManager + * Language manager service.A definite article is missing in both the descriptions.
It is not necessary to say service, as the language manager is a service, on Drupal. - Status changed to Needs review
almost 2 years ago 11:12am 17 May 2023 - Status changed to RTBC
over 1 year ago 11:49am 24 May 2023 - 🇧🇷Brazil lucienchalom
The sugestion was fixed, and the Drupal call was changed to a dependency injection,
RTBC