Refactor to use static closure (2)

@baldwinlouie, @xiaohua-guan, @masami, @sekinet

Can you please review the patch? Thanks!

@yas

It looks good to me. Thanks.

@yas, Thank you for the patch. It looks good to me.

@yas

Thanks for the patch. It looks good to me.

The patch looks good to me, so I change the status to RTBC.

@sekinet @baldwinlouie @xiaohua-guan @masami

Thank you for your review. I'll merge the patch to 4.x, 5.x and 6.x, and close this issue as Fixed.

We need to fix the following error:

Error: Using $this when not in object context in Drupal\aws_cloud\Plugin\Block\LowUtilizationInstancesBlock::Drupal\aws_cloud\Plugin\Block\{closure}() (line 217 of /var/www/cloud_orchestrator/docroot/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Plugin/Block/LowUtilizationInstancesBlock.php)
#0 [internal function]: Drupal\aws_cloud\Plugin\Block\LowUtilizationInstancesBlock::Drupal\aws_cloud\Plugin\Block\{closure}(Object(Drupal\aws_cloud\Entity\Ec2\Instance))
#1 /var/www/cloud_orchestrator/docroot/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Plugin/Block/LowUtilizationInstancesBlock.php(216): array_map(Object(Closure), Array)
#2 /var/www/cloud_orchestrator/docroot/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Plugin/Block/LowUtilizationInstancesBlock.php(191): Drupal\aws_cloud\Plugin\Block\LowUtilizationInstancesBlock->buildInstanceList()
#3 /var/www/cloud_orchestrator/docroot/profiles/contrib/cloud_orchestrator/src/Controller/DashboardController.php(263): Drupal\aws_cloud\Plugin\Block\LowUtilizationInstancesBlock->build()
#4 /var/www/cloud_orchestrator/docroot/profiles/contrib/cloud_orchestrator/src/Controller/DashboardController.php(165): Drupal\cloud_orchestrator\Controller\DashboardController->getBlock('aws_cloud_low_u...', Array)
#5 /var/www/cloud_orchestrator/docroot/profiles/contrib/cloud_orchestrator/src/Controller/DashboardController.php(54): Drupal\cloud_orchestrator\Controller\DashboardController->getAwsBlocks()
#6 [internal function]: Drupal\cloud_orchestrator\Controller\DashboardController->getDashboard()

This is the hotfix.

@all The tests have been passed successfully, so I'll merge the patch to 4.x, 5.x and 6.x, and close this issue as Fixed.

Automatically closed - issue fixed for 2 weeks with no activity.