image_captcha_update_9002 incorrectly updated image_captcha instead of captcha title

Thanks @heddn! @Grevil could you have a look, please? If someone could provide a MR earlier, that would be super nice :)

Edit: X-Post! Thanks for the patch! :)

Thank you, @heddn! I think the update hook is not properly implemented, sorry!

There shouldn't be an "image_captcha" "title" config key. Instead, the "captcha" "title" value should've been set there.

Fixed, please review.

Should this update be moved from image_captcha into captcha?

@Grevil could you have a look again, please?

Since we are removing config from image_captcha and adding it to captcha, we need to have both modules activated. We could also only remove the config from image_captcha and be done with it, without touching "captcha", so if people renamed their captcha title to something else, it won't be reset to "CAPTCHA". Either way, this is image_captcha specific.

Thank you @heddn and @Grevil! Changes LGTM, #10 sounds reasonable to me. As it was wrongly added in image_captcha, I think it should also be removed in there.

Let's get this fixed! :)

Merged, thank you!

As stated in #10 the patch is generally fine as is, BUT we should create an update hook, warning the user, that their potential custom Captcha title will be replaced with "Captcha" and that they have to rename it accordingly after the update.

Creating a follow-up issue.

See 📌 [Follow-up] image_captcha_update_9002 incorrectly updated image_captcha instead of captcha title Fixed .

We will adjust the test properly inside 📌 [Follow-up] image_captcha_update_9002 incorrectly updated image_captcha instead of captcha title Fixed .

@heddn you are completely correct, the update hook should have never existed in image_captcha, but rather in captcha...

Sry, it seems like I over read your comment in #8.

We will fix everything in the follow up issue.

Automatically closed - issue fixed for 2 weeks with no activity.