- Issue created by @pasqualle
- Assigned to akshaydalvi212
- @akshaydalvi212 opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:43am 24 April 2023 - ๐ฎ๐ณIndia akshaydalvi212
I had replace the depreciated code for HTTPClient and also solve some coding issues with the branch.
kindly review the MR. - First commit to issue fork.
-
itamair โ
committed 15685b09 on 8.x-4.x
Issue #3355990 by akshaydalvi212, itamair, Pasqualle: Http\Client\...
-
itamair โ
committed 15685b09 on 8.x-4.x
-
itamair โ
committed b0560eda on 8.x-3.x
Issue #3355990 by akshaydalvi212, itamair, Pasqualle: Http\Client\...
-
itamair โ
committed b0560eda on 8.x-3.x
-
itamair โ
committed 209e723e on 8.x-3.x
Issue #3355990 by akshaydalvi212: HttpClient is deprecated
-
itamair โ
committed 209e723e on 8.x-3.x
- Status changed to Fixed
over 1 year ago 11:05pm 25 April 2023 - ๐ฎ๐นItaly itamair
Thanks a lot. This was committed into the 8.x-4.x-dev branch, is going to be part of next Geocoder release
- ๐ฎ๐ณIndia rajeshreeputra Pune
With this changes now unable to install site with Drupal 10.0.7.
[error] Error: Cannot instantiate interface Psr\Http\Client\ClientInterface in Drupal\Component\DependencyInjection\Container->createService() (line 259 of /home/runner/work/acquia_cms/orca-build/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php) #0 /home/runner/work/acquia_cms/orca-build/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
- Status changed to Needs work
over 1 year ago 8:11am 27 April 2023 - ๐ฎ๐นItaly itamair
Nice catch @Rajeshreeputra ... super thanks for this. Reopening this then.
- ๐ฎ๐ณIndia vishalkhode
vishalkhode โ made their first commit to this issueโs fork.
- @vishalkhode-0 opened merge request.
-
itamair โ
committed 2309c80e on 8.x-3.x
Rollback of regressive fixes to Issue #3355990 by akshaydalvi212,...
-
itamair โ
committed 2309c80e on 8.x-3.x
- First commit to issue fork.
- Assigned to ankitv18
- ๐ฎ๐นItaly itamair
I was too quick (and confident) with the initial fixes / contributions to this issue (that also affected the 3.x branch).
Please provide a full QA and Testing of what is being done here, so that I could perform mine one, being confident this properly marked as RTBC ...
This has become a super adopted module, so that any critical regression introduced would reflect in a big mess, coming from everywhere. - ๐ฎ๐ณIndia rajeshreeputra Pune
To avoid these type of issue in future lets add testcase coverage in separate ticket.
-
itamair โ
committed a860b4d8 on 8.x-4.x
Issue #3355990 by itamair, Rajeshreeputra, akshaydalvi212, ankitv18,...
-
itamair โ
committed a860b4d8 on 8.x-4.x
- Status changed to Fixed
11 months ago 11:13pm 6 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.