- Issue created by @penyaskito
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
I *think* this could be removed and there would be no effect.
Because if I set a view as the homepage, the homepage will already have that #title. So if we consider that a bug, the bug is already in core. - First commit to issue fork.
- Merge request !3878Removed unused condition head title for views → (Open) created by Unnamed author
- last update
almost 2 years ago 29,299 pass, 2 fail - Status changed to Needs review
almost 2 years ago 4:43am 26 April 2023 - Status changed to Needs work
almost 2 years ago 3:28pm 26 April 2023 - 🇺🇸United States smustgrave
Needs failure seems legit to this.
And as mentioned a test case showing this should be included. As removing it did break a test.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
penyaskito → changed the visibility of the branch 3355678-cleanup-head-title to hidden.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
penyaskito → changed the visibility of the branch 11.x to hidden.
- Merge request !10675Issue #3355678: Cleanup: Head title shouldn't have a special case for views → (Open) created by penyaskito
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
When I created this, I wrote the Proposed resolution as:
"The test should create a view, set it as the home, and ensure the title is Home and not the views title."
Which currently with HEAD is not even true.
If I create a view, set it as the home, the title won't be Home but the views title.So we first need to define if that's the correct behavior.