- Issue created by @wim leers
- Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @wim-leers opened merge request.
- Status changed to Needs review
over 1 year ago 1:58pm 20 April 2023 - last update
over 1 year ago 29,291 pass - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Analyzed the release notes. AFAICT we need manual testing for:
Table
("Table") plugin: 🐛 [upstream] CKEditor 5 mangles table structure Fixed — verify if it is fixed in its entirety or partiallyTextPartLanguage
("Language") plugin: 37.1.0 made a change to<span lang="fr">Bonjour</span>
— that'd have been italic until this release. This may require us adding.ck-content span[lang] { font-style: italic; }
tocore/modules/ckeditor5/css/language.css
… or not. Because we already have this in place:
.ck-content [lang] { outline: 1px dotted gray; }
Arguably this is actually a net improvement, and avoids user confusion — that's also why this was done in the first place: https://github.com/ckeditor/ckeditor5/issues/12672.
That needs a decision from a front-end framework manager. Tagging accordingly.
- 🇫🇮Finland lauriii Finland
I think we want to refrain from making the text italic to benefit from the UX fix. It looks like we have an alternative affordance in place already so that's good 👍
- 🇺🇸United States bnjmnm Ann Arbor, MI
I agree the outline is an improvement as it is visually distinguishing the [lang] use in a manner that won't be confused with intentionally italicized text.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Excellent, thanks both of you! Then also untagging .
- Status changed to RTBC
over 1 year ago 10:44pm 24 April 2023 - 🇺🇸United States smustgrave
Applied the MR locally and following 🐛 [upstream] CKEditor 5 mangles table structure Fixed
Pasted
<table> <tr> <th>Header</th> <th>Header</th> <th>Header</th> </tr> <tr> <th>Header</th> <td>Data</td> <td>Data</td> </tr> </table>
and got
<table> <tbody> <tr> <th> Header </th> <th> Header </th> <th> Header </th> </tr> <tr> <th> Header </th> <th> Data </th> <th> Data </th> </tr> </tbody> </table>
Gross
Applied the patch and tried again but this time I got
<table> <thead> <tr> <th> Header </th> <th> Header </th> <th> Header </th> </tr> </thead> <tbody> <tr> <th> Header </th> <td> Data </td> <td> Data </td> </tr> </tbody> </table>
Which seems correct as the th's were wrapped in a thead vs tbody like before.
Spot checked some other plugins but didn't notice anything.
- last update
over 1 year ago 29,304 pass - Status changed to Fixed
over 1 year ago 9:39am 25 April 2023 - 🇬🇧United Kingdom catch
Let's get this in before the alpha so it gets as much testing as possible.
Committed/pushed to 10.1.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.