Fix the issues reported by phpcs

I have reviewed the patch seems you deleted some files you need to fix it

I think it is resolved now. Thank you for helping, I appreciate it.

Yes, the patch removed files instead of renaming them. Also, the files, even when renamed, should still be changed to fix the coding standards.

Hi thank you for helping out. Feel free to submit a merge request once you have fixed the issues you feel exist.
Thanks!

@earlybug please apply the latest patch.

There is a discrepancy on line 24 of the patch were it says -
- _permission: 'administer site configuration'
+ _permission: 'access administration pages'

I'm keeping the access checks as-is to keep it more fine grained in a scenario where there are admins with various permission levels on a system. For instance an admin should have access to all admin pages but not settings that can affect specific settings.

I think it would be easy to just create a custom permission setting for this module like "access random frontpage settings" and this would be the best route.

Also it looks like although in this patch we remove the old controller under the old nomenclature, we don't replace it with a new file. :)

A custom permission is fine too, as long as the route does not use the access administration pages, which is only for accessing administration pages, not change any setting.

Yes, it is quite confusing that Drupal uses that permission, which should not be used to allow changing settings. I guess it should only be used on routes like /admin/reports/dblog (but that route uses a custom permission, access site reports).

@apaderno
The permissions issue has been resolved with the latest release found here:
https://www.drupal.org/project/random_frontpage/releases/2.0.0-beta7 →

We have to change the filename as per Drupal stranded.
below as some issue on PHPCS.

FILE: /home/shivsharma/project/my-drupal10-site/web/modules/contrib/random_frontpage/src/Controller/random_frontpageController.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | Class name must begin with a capital letter
 17 | ERROR | Class name must use UpperCamel naming without underscores
 70 | ERROR | Missing short description in doc comment
 71 | ERROR | Missing parameter comment
 72 | ERROR | Description for the @return value is missing
 88 | ERROR | Description for the @return value is missing

FILE: /home/shivsharma/project/my-drupal10-site/web/modules/contrib/random_frontpage/src/Form/random_frontpageSettings.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------------
  11 | ERROR | Doc comment is empty
  14 | ERROR | Class name must begin with a capital letter
  14 | ERROR | Class name must use UpperCamel naming without underscores
  30 | ERROR | Missing short description in doc comment
 111 | ERROR | Description for the @return value is missing

FILE: /home/shivsharma/project/my-drupal10-site/web/modules/contrib/random_frontpage/random_frontpage.module
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 3 | ERROR | Missing short description in doc comment
------------------------------------------------------------------------------------------------------------

@Shiv_Sharma - patch file does not contain updates from the latest release, so I can't use them.
Naming conventions do not affect performance.
I will perform more updates soon.
I appreciate it.

These issues are addressed in the latest release found here:
https://www.drupal.org/project/random_frontpage/releases/2.0.0-beta8 →
Please verify and thank you for your help, I appreciate it.

No new issue reported by PHPCS, we are good with this version.(attached screenshot)
also tested the module functionality working as expected.