Coding standards

Hi Shashank Kumar

Nice Module and it's very useful

Hi Dinesh Kumar Bollu,

We have already followed the coding standard Please check the latest branch: https://git.drupalcode.org/project/imagecroper/-/tree/2.0.x?ref_type=heads

Hi ,

there is Coding standards issues

FILE: ...oper/imager_widget/src/Plugin/Field/FieldWidget/ImagerWidget.php
----------------------------------------------------------------------
FOUND 45 ERRORS AFFECTING 35 LINES
----------------------------------------------------------------------
75 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 3
76 | ERROR | [x] Whitespace found at end of line
77 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 6
78 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 6
79 | ERROR | [x] Whitespace found at end of line
80 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
| | found 8
80 | ERROR | [x] Expected 1 space after IF keyword; 0 found
80 | ERROR | [x] Expected 1 space before ">"; 0 found
80 | ERROR | [x] Expected 1 space after ">"; 0 found
80 | ERROR | [x] Expected 1 space after closing parenthesis; found
| | 0
81 | ERROR | [x] Whitespace found at end of line
82 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
| | found 10
83 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
| | found 10
83 | ERROR | [x] Comments may not appear after statements
84 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
| | found 10
85 | ERROR | [x] Whitespace found at end of line
86 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
| | found 10
87 | ERROR | [x] Whitespace found at end of line
88 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
| | found 10
88 | ERROR | [x] Expected 1 space after IF keyword; 0 found
88 | ERROR | [x] Expected 1 space before ">"; 0 found
88 | ERROR | [x] Expected 1 space after ">"; 0 found
88 | ERROR | [x] Expected 1 space after closing parenthesis; found
| | 0
89 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
| | found 12
90 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
| | found 12
91 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
| | found 12
92 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
| | found 12
93 | ERROR | [x] Whitespace found at end of line
94 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
| | found 11
95 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
| | found 12
96 | ERROR | [x] Whitespace found at end of line
97 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
| | found 12
98 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
| | found 12
99 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
| | found 6
100 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
| | found 12
101 | ERROR | [x] Line indented incorrectly; expected 12 spaces,
| | found 14
102 | ERROR | [x] Line indented incorrectly; expected 12 spaces,
| | found 14
103 | ERROR | [x] Line indented incorrectly; expected 10 spaces,
| | found 12
104 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
| | found 10
105 | ERROR | [x] Whitespace found at end of line
106 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
| | found 8
107 | ERROR | [x] Whitespace found at end of line
108 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
| | found 4
109 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
| | found 3
109 | ERROR | [x] Closing brace indented incorrectly; expected 6
| | spaces, found 3

Applied patch

@chanderbhushan, I have fixed the coding issue. Also, I have run the phpcs but not found any now. Please see the screenshot.

Please test and confirm.

I have cloned your module
git clone --branch '1.0.x' https://git.drupalcode.org/project/imagecroper.git

Please see attached screenshot

@chanderbhushan,

Please clone latest branch.

git clone --branch '3.0.x' https://git.drupalcode.org/project/imagecroper.git