Contrib.social

Coding standards

Open on Drupal.org →
Created on 19 April 2023, over 1 year ago

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/oswald/

FILE: /var/www/html/drupalvb/web/modules/contrib/oswald/oswald.links.menu.yml
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
13 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/oswald/src/Form/ConfigForm.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
76 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
79 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
103 | ERROR | [x] No space found before comment text; expected "// 'selected_only' => $this->t('Selected paths only')," but found "//'selected_only' => $this->t('Selected paths only'),"
104 | ERROR | [x] No space found before comment text; expected "// 'selected_not' => $this->t('Everywhere except selected paths')," but found "//'selected_not' => $this->t('Everywhere except selected
| | paths'),"
133 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
133 | ERROR | [x] No space found before comment text; expected "// ->set('content_type_filters', $form_state->getValue('content_type_filters'))" but found "//->set('content_type_filters',
| | $form_state->getValue('content_type_filters'))"
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/oswald/src/Form/ConfigTestForm.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
68 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
72 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
74 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
83 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/oswald/oswald.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
51 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/oswald/oswald.routing.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
21 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/oswald/oswald.info.yml
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
----------------------------------------------------------------------------------------------

Time: 332ms; Memory: 12MB

📌 Task
Status

Closed: won't fix

Version

4.0

Component

Code

Created by

🇮🇳India dineshkumarbollu

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @dineshkumarbollu
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India dineshkumarbollu
  • Status changed to Closed: won't fix over 1 year ago
  • Comment over 1 year ago →
    🇧🇪Belgium BramDriesen Belgium 🇧🇪

    To discourage people from adding issues, patches or MRs that appear to seek easy commit credits I will not be merging these types of requests. Generally, these tickets create unnecessary noise and maintainer workload.
    If however you feel I'm unfairly confused a meaningful contribution with attempts motivated by earning commit credit, please respond and let me know. I don't want to stand in the way of genuine contribution, only to preserve the valuable time and energy available in the community for meaningful efforts. If I've got this wrong, I want to hear from you.

    Some extras:
    Note this is the second issue from ValueBound in 24h to fix the same thing.
    The patch doesn't even look to be for the correct branch (there is no paragraphs dependency)

    +++ b/oswald.info.yml
@@ -6,4 +6,4 @@ core_version_requirement: ^8 || ^9
-  - paragraphs
+  - Oswald: paragraphs

    How is this even a correct dependency?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024