[1.0.x] User status popup

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

Fix PHPCS issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml file_rename/

FILE: /var/www/html/web/modules/contrib/check_username/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 89 characters
----------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/check_username/src/Controller/CheckUsernameController.php
-------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------
 17 | ERROR   | Missing parameter comment
 19 | ERROR   | Description for the @return value is missing
 26 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/check_username/check_username.module
--------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------
 14 | ERROR   | [x] Opening brace should be on the same line as the declaration
 26 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 29 | WARNING | [x] A comma should follow the last multiline array item. Found: 'user_form'
 34 | ERROR   | [x] Expected 1 space(s) after cast statement; 0 found
 35 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/check_username/check_username.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

Time: 281ms; Memory: 10MB

@MahmoudSayed96 Please confirm which project to review. user_status_popup or check_username ?

@MahmoudSayed96, Please remove these thing from user_status_popup.info file.

FILE: /user_status_popup/user_status_popup.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

Time: 161ms; Memory: 10MB

@shashank5563 You need to run phpcs on the cloned project, not on the installed project.

The content of the committed file is the following.

name: 'User Status Popup'
type: module
description: 'Show user form status as button and fire popup confirm form'
core_version_requirement: ^8 || ^9 || ^10
package: 'Other'

The lines reported by comment are not present. They are added from the drupal.org packaging script to the file added in the module archive.

I am changing priority as per Issue priorities → .

This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.