- Issue created by @ericvl
- 🇧🇪Belgium ericvl
Remark: The example in the settings page of image_captcha is OK.
Only the thumbnails of Tuffy, Tuffy Bold and Tesox are not shown. - 🇩🇪Germany Anybody Porta Westfalica
This is a regression from: #3321861: Change image_captcha submodule and test modules location. → for custom font paths, I think.
So I think this is a duplicate of 🐛 Moving the module in the file system breaks configured fonts Active .While the cleanup was necessary and of course shouldn't have broke this, someone needs to fix it. I'll leave both issues open for now, as this one also provides helpful further information, but we should consider closing it as duplicate.
- Status changed to Postponed
over 1 year ago 9:39am 7 June 2023 - 🇩🇪Germany Anybody Porta Westfalica
This is a regression from: #3321861: Change image_captcha submodule and test modules location. → for custom font paths, which also existed before, if the whole CAPTCHA module was moved in the file system.
So I think this is similar to 🐛 Moving the module in the file system breaks configured fonts Active and has the same root cause.
While the cleanup was necessary, but of course shouldn't have broke this, someone needs to fix it. I won't close this issue as duplicate, as it well describes the situation and steps to reproduce when upgrading to 2.x without moving the captcha module.
The reason is clearly described in 🐛 Moving the module in the file system breaks configured fonts Active and should be fixed there, so I'll postpone this on on that.
- Status changed to Postponed: needs info
over 1 year ago 10:22am 7 June 2023 - 🇩🇪Germany Anybody Porta Westfalica
Just had a deeper look and found out that this should have been fixed in #3321861: Change image_captcha submodule and test modules location. → implementing image_captcha_update_9001. So I'm wondering if this is a special case, perhaps the value was custom or has been changed before.
Can you reproduce this in a vanilla environment?
- Status changed to Needs review
over 1 year ago 12:21pm 7 June 2023 - 🇩🇪Germany Anybody Porta Westfalica
Found it and I'm sure, @Grevil will cry and laugh at the same time... no idea how that could happen, but I also didn't see it in my review.
Human error. Should not happen.
Blame: https://git.drupalcode.org/project/captcha/-/commit/988a3165d7701fa4c469...MR attached. So simple, it hurts.
- last update
over 1 year ago 44 pass - @anybody opened merge request.
- Status changed to Needs work
over 1 year ago 12:43pm 7 June 2023 - 🇩🇪Germany Grevil
I don't think, that is correct. Through the Drupal 10 release, the Symfony library updated and the sendContent() method changed. This is the current implementation:
/** * This method only sends the content once. * * @return $this */ public function sendContent(): static { if ($this->streamed) { return $this; } $this->streamed = true; if (null === $this->callback) { throw new \LogicException('The Response callback must not be null.'); } ($this->callback)(); return $this; }
As you can see, the methods returns $this now and has the typehint "static". If we would remove the return, it would resolve to void and we'll get an PHP error.
- 🇩🇪Germany Grevil
OK, I should get new Glasses. I probably thought, the method would end on line 57. 😅
My apologies! - last update
over 1 year ago 44 pass - last update
over 1 year ago 44 pass - Status changed to Fixed
over 1 year ago 1:34pm 7 June 2023 - 🇩🇪Germany Anybody Porta Westfalica
@EricVL please try 2.0.0-beta3! :) It it fixed?
But mind 🐛 Response classes seem incompatible with WebProfiler Active if you're using WebProfiler module!
- 🇧🇪Belgium ericvl
@Anybody - Yes, it works now with this beta3 release.
Great job - Thank you.
Have a nice day Automatically closed - issue fixed for 2 weeks with no activity.