Move isRenderArray from SDC to Drupal\Core\Render\Element

Blocker is in, this can proceed.

I will try to see it.

Hi can you give more detials?

I pushed a commit with the needed changes to the MR branch. That was easier for me than explaining it. 😅

I will review it.

@elber I am familiar with this code. If you don't mind I can do a quick RTBC.

1. The code is moved to the Element class.
2. The calling code is updated.
3. The tests are moved to the corresponding test class.
4. The old class is removed.
5. The old test class is removed.
6. All tests are passing in 10.1.x.

This looks good to me and straight forward. RTBC.

Setting this to Postponed, since we have to wait for the 10.1.x-alpha1 to be tagged before we can merge this one in 10.1.x-dev.

Apologies for not thinking of this earlier.

Also open a MR to 📌 Move code from the experimental SDC module to core Fixed to the meta issue. See gitlab.

Removing postponed status, it could be merged in the the parent issue that will move everything i think. So back to RTBC. Perhaps we should wait with merging until we have a more clear path on theother parts?

@dww any chance you can update to MR to merge against the branch 3345922-single-directory-components instead of 10.1.x?

There should be a Mr made for that merge also. But it won't show in here since it is made through gitlab.

I made a Mr to the parent branch for each issue.

Hmm, this was the pre existing one. I might have not done that.

I can work on it Tuesday if no one beats me to it. 😅

Hrm, there's no issue fork at 🌱 Single Directory Components module roadmap: the path to beta and stable Active . 3345922-single-directory-components doesn't seem to exist.

Did y'all want this rebased vs. https://git.drupalcode.org/issue/drupal-3352256/-/tree/3352256-meta-move... via the issue fork at 📌 Move code from the experimental SDC module to core Fixed ?

I think this is fine. As @dww pointed out this was already RTBC, and it will be reviewed by core committers in 📌 Move code from the experimental SDC module to core Fixed .

Question is, what should be the status of this? Fixed?

Maybe @lauriii can help with the status.

Automatically closed - issue fixed for 2 weeks with no activity.