- Issue created by @siemen_hermans
- Status changed to Needs work
over 1 year ago 3:30pm 5 April 2023 - 🇫🇷France Grimreaper France 🇫🇷
Hi,
Nice catch, thanks!
Please use fork/MR workflow and in the patch proper dependency injection.
If you don't know that, I will do it in next few days.
- Assigned to Chandreshgiri Gauswami
- Status changed to Active
over 1 year ago 7:14am 6 April 2023 - @chandreshgiri-gauswami opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:50am 6 April 2023 The last submitted patch, 5: 3352342-5.patch, failed testing. View results →
- Status changed to Needs work
over 1 year ago 3:20pm 11 April 2023 - First commit to issue fork.
- Status changed to Needs review
over 1 year ago 6:35pm 11 April 2023 - Status changed to Needs work
over 1 year ago 4:21pm 12 April 2023 - 🇫🇷France Grimreaper France 🇫🇷
Tests are still failing.
The proposed code was just a suggestion and not a solution to copy/past without testing.
- 🇧🇷Brazil elber Brazil
My suggestion is keep with construct and create method, what do you think?
- Assigned to Grimreaper
- last update
over 1 year ago 2 pass -
Grimreaper →
committed a31f6802 on 2.0.x authored by
Chandreshgiri Gauswami →
Issue #3352342 by Chandreshgiri Gauswami, Grimreaper, elber,...
-
Grimreaper →
committed a31f6802 on 2.0.x authored by
Chandreshgiri Gauswami →
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 7:12pm 23 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.