- Issue created by @Emanuel Moreira
- 🇵🇹Portugal Emanuel Moreira
I created a patch to convert special characters to HTML entities.
- Status changed to Needs review
over 1 year ago 12:05pm 8 May 2023 - last update
over 1 year ago Patch Failed to Apply - 🇩🇪Germany Anybody Porta Westfalica
It seems like this can be reproduced by creating a Glossify term containing an ampersand ("&"). And then running the replacement.
Could someone please try to reproduce this and then write a test?
Maybe also for other special characters? - Status changed to Needs work
2 months ago 3:58pm 4 September 2024 - 🇩🇪Germany Anybody Porta Westfalica
Okay I at least found a way to fix the errors, but I think the replacement may not work propely in all cases now, but that's less important.
Hotfix attached in MR. For further implementation, this should first have tests.
- 🇩🇪Germany Anybody Porta Westfalica
Okay I at least found a way to fix the errors, but I think the replacement may not work propely in all cases now, but that's less important.
Hotfix attached in MR. For further implementation, this should first have tests.
- Status changed to Needs review
2 months ago 4:09pm 4 September 2024 - 🇩🇪Germany Anybody Porta Westfalica
Green tests are not enough here due to missing test coverage, but I think if the hotfix from MR!27 works, we should merge it already to improve the risk for people running into this.
We should keep this major and add tests next to reproduce it.
In my case it happened on taxonomy terms with the title "Lorem & ipsum". It resulted in user session being discarded due to the errors.
- 🇩🇪Germany Anybody Porta Westfalica
Merged the hotfix! See #9 for further steps.
- Assigned to Grevil
- Status changed to Needs work
2 months ago 4:11pm 4 September 2024 - Merge request !28Add a test with special html characters in the taxonomy term title → (Open) created by Anybody
- 🇩🇪Germany Anybody Porta Westfalica
I started with https://git.drupalcode.org/issue/glossify-3351345/-/tree/3351345-test-only
that needs to be completed, but even then it's not yet sure it will fail (but it's definitely a good test to add).
But for the test-only we'll need to revert the fix there!