- Issue created by @tedbow
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
As discussed earlier today: the maintenance mode check could and should be done in a validator.
Other than that: 👏 Yes, please! 😊
- Assigned to omkar.podey
- @omkarpodey opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:45am 6 April 2023 - Assigned to omkar.podey
- Status changed to Needs work
over 1 year ago 12:02pm 6 April 2023 - 🇮🇳India omkar.podey
Created 📌 [PP-1] Create a validator to check if site is in maintenance mode while package manager is in use. Postponed , should we block this issue on it ?
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:03am 7 April 2023 - Assigned to omkar.podey
- 🇮🇳India yash.rode pune
I think, as we are going to check that in a validator now, we don't assume that anymore it's explicitly checked. So we should remove the assumption of maintenance mode from package_manager.api?
Also, we don't need to block this issue on 📌 [PP-1] Create a validator to check if site is in maintenance mode while package manager is in use. Postponed .
If this sounds good to you, can assign this to @tedbow for further review, it looks good to me. - Assigned to tedbow
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Only one of the two things mentioned in the issue summary are in the merge request?
- last update
over 1 year ago 715 pass - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 9:40am 18 April 2023 - Assigned to omkar.podey
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:23am 18 April 2023 - Status changed to RTBC
over 1 year ago 11:23am 18 April 2023 - 🇺🇸United States phenaproxima Massachusetts
Crediting myself for a review that helped shape the text.
- 🇺🇸United States phenaproxima Massachusetts
Crediting @yash.rode for review.
-
phenaproxima →
committed c329281e on 3.0.x authored by
omkar.podey →
Issue #3351069 by omkar.podey, tedbow, Wim Leers, yash.rode,...
-
phenaproxima →
committed c329281e on 3.0.x authored by
omkar.podey →
- Status changed to Fixed
over 1 year ago 3:31pm 18 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 2:29pm 3 May 2023