- Issue created by @Grevil
- Status changed to Needs work
about 2 years ago 12:06pm 27 March 2023 - 🇩🇪Germany Anybody Porta Westfalica
Thx @Grevil, could you please provide a MR with fixes? Thanks!!
- @grevil opened merge request.
- Status changed to Needs review
about 2 years ago 12:52pm 27 March 2023 - 🇩🇪Germany Grevil
Done! In my understanding, we do not need to implement the "hook_library_info_build" as it is only required for libraries, which need dynamic runtime information, but in this case there are none. Please correct me if I am wrong (Also fixed phpcs issues).
- Assigned to Grevil
- Status changed to Needs work
about 2 years ago 1:10pm 27 March 2023 - 🇩🇪Germany Anybody Porta Westfalica
@Grevil: Yes, I agree. Looks like we also don't need permissions_dragcheck_library_info_alter()? Could you check that?
https://www.drupal.org/node/2201089 → confirms your comment in #4 I think.
Still to be 100% sure please test manually after merging into dev and before creating a new release.
If you ensure both libraries are loaded correctly on the permission administration pages in 📌 Add basic install / uninstall and library loading test Postponed , we're 100% safe. - Status changed to RTBC
about 2 years ago 1:40pm 27 March 2023 - 🇩🇪Germany Grevil
Ok, I'll commit this to dev and test everything inside 📌 Add basic install / uninstall and library loading test Postponed .
- Status changed to Fixed
about 2 years ago 1:41pm 27 March 2023 - First commit to issue fork.
Automatically closed - issue fixed for 2 weeks with no activity.