- Issue created by @rkoller
- First commit to issue fork.
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
@rkoller to my knowledge this is already provided by Drupal core. see:
- 🇩🇪Germany rkoller Nürnberg, Germany
yes
skip to main
is already provided by Drupal core. But the suggestion in ✨ [meta] Address accessibility concerns Active was to provide a similar link forskip to preview
making the switch to the preview window easier. cuz at the moment a user has to tab through all the focusable elements that come after the toggle preview button as illustrated in tab.mp4 - @cosmicdreams opened merge request.
- 🇩🇪Germany rkoller Nürnberg, Germany
i've applied the patch. one initial feedback. at first i haven't found the
skip to preview
button until i've noticed that the button is shown when you tab inside the preview window. i've assumed it would show up outside on the node edit form meaning on the the first tab press when the user is leaving the focus of thetoggle preview
button.but i've realized after testing a little bit more that without the patch a user would be unable to get inside the preview window (always circling inbetween quit, refreseh, new window and view mode), that's an complete oversight on my end. but i wonder if it would make sense to add such a visually-hidden button on the node edit form as described above additionally. that way a user could easily skip to the off-canvas preview if the preferred way of navigation is the tab key. and then within the preview controls there would be the option to skip inside the preview as well.
but in the end there would have to be an easy way out aka link as well i suppose? otherwise the user would be stuck inside the preview iframe.
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
@rkoller There are two ways we could move the "skip to preview button" out of the PreviewControlsForm that we're adding with this module.
1. Hack / Override Core's node template. We've been avoiding such overrides because we'd then have to continue supporting that for everything theme.
2. Use javascript to override that link (also problematic).Adding our own link is the path of least resistance and the easier thing to support as we're not breaking expectations / backwards compatibility by adding something new.
-----
Let's create a new issue for adding another (skip to preview) link to the node edit form.
- Status changed to Needs review
over 1 year ago 3:53pm 26 March 2023 - Status changed to Needs work
over 1 year ago 10:06am 27 March 2023 - 🇩🇪Germany rkoller Nürnberg, Germany
In #6 📌 Make the preview window easier reachable via the keyboard with a skip to preview link Needs work i've only tried to find the skip to preview link by tabbing i haven't had actually clicked it. there are actually two problems with it.
1. when clicking the skip to preview content button the inception turned up again (ref 🐛 Installation on already existing sites broken with no real preview shown Fixed - see inception.mp4)
2. clicking theskip to preview content
button actually opens a new window. that way you have for keyboard users redundant functionality. first the visually hiddenskip to preview content
button opening a preview (and technically speaking it isnt skipping but opening a new window) then therefresh
button and then thenew window
button. i wonder if it wouldnt be the better choice to remove theskip to preview content
and work on the wording for the new window string. cuznew window
isn't necessarily clear to the user what it means and implies. me for example, i associatenew window
with the new window command in the browser aka i would expect an empty browser window in particular if i am able to see the actual preview underneath already. therefore it always makes me think for a second.