- Status changed to Needs work
over 1 year ago 9:58am 20 March 2023 - 🇳🇴Norway gisle Norway
Thanks for the MR. It looks like it needs work as it test reports it is not mergeable.
- Status changed to Active
over 1 year ago 1:38pm 20 March 2023 - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:43pm 20 March 2023 - 🇮🇳India rckstr_rohan
Created a patch for Drupal 10 Compatibility Fixes, please review.
- Status changed to Postponed: needs info
over 1 year ago 4:13pm 20 March 2023 - heddn Nicaragua
Why is this patch needed? https://www.drupal.org/pift-ci-job/2618883 → Shows things already pass on D10.
- Status changed to Needs review
over 1 year ago 7:08am 21 March 2023 Explicit access check is Mandatory for Drupal 10 and its missing in the module's MigrateExecutionFormTest testcase file. So we have added the access check.
Please review it.- Status changed to Closed: won't fix
over 1 year ago 3:16pm 21 March 2023 - heddn Nicaragua
Look at
setup(), it already sets the query up with access checking. This isn't needed. - Status changed to Needs review
over 1 year ago 10:05am 23 March 2023 Even though the accessCheck is present in setup(), upgrade_status module is still providing deprecated warning. Please check the warning below:
Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.
- Status changed to Closed: won't fix
over 1 year ago 11:52am 23 March 2023 - heddn Nicaragua
No matter, the tool is giving a false result. We have green tests on d10. This won't be changed.
- 🇩🇰Denmark ressa Copenhagen
I just tried running the migrate_example module in Drupal 10, and the current official release worked well.