- Issue created by @carolpettirossi
- @carolpettirossi opened merge request.
- Status changed to Needs review
over 1 year ago 4:18pm 3 April 2023 - 🇺🇸United States chrissnyder Maryland
This current change would make the domain module a dependency of sitewide_alert, requiring anyone who wanted sitewide alerts to install the domain module.
I really like the idea of supporting the domain module but I want to help remove the direct dependency on the domain module and make the feature only available to those who need it.
One option might be able to remove this dependency by creating a submodule, `sitewide_alert_domain`, that would extend → /decorate the existing SitewideAlertManager class/service. Or in that submodule, would s ubscribe to an event → that we add/dispatch from the existing SitewideAlertManager.
- Status changed to Needs work
over 1 year ago 2:01pm 9 May 2023 - last update
over 1 year ago 4 pass, 2 fail - last update
over 1 year ago Build Successful - 🇺🇸United States SocialNicheGuru
I go this error in my logs and the sitewide_alerts block did not show up
TypeError: Drupal\sitewide_alert\SitewideAlertManager::__construct(): Argument #6 ($domainNegotiator) must be of type Drupal\domain\DomainNegotiatorInterface, null given, called in /drupal9.5.6/html/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\sitewide_alert\SitewideAlertManager->__construct() (line 87 of /drupal9.5.6/html/modules/contrib/sitewide_alert/src/SitewideAlertManager.php)
- last update
over 1 year ago 8 pass - last update
over 1 year ago 8 pass - last update
over 1 year ago 8 pass - last update
over 1 year ago 8 pass - Status changed to Needs review
over 1 year ago 9:27pm 20 June 2023 - 🇧🇷Brazil carolpettirossi Campinas - SP
ChrisSnyder,
Thanks for your great suggestions on how to integrate properly with Domain module and sorry for taking so long to rewrite this.
I believe this is ready for review again.
- last update
over 1 year ago 8 pass - last update
over 1 year ago 8 pass - last update
over 1 year ago 8 pass -
ChrisSnyder →
committed 72cd7cb0 on 2.x authored by
carolpettirossi →
Issue #3348584 by carolpettirossi, ChrisSnyder: Integration with Domain...
-
ChrisSnyder →
committed 72cd7cb0 on 2.x authored by
carolpettirossi →
- Status changed to Fixed
over 1 year ago 1:41pm 31 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.