- Issue created by @mvonfrie
- @mvonfrie opened merge request.
- π¦πΉAustria mvonfrie
Fixed. Tests are failing due to π Schema registration_form_mode in commerce checkout pane is missing Closed: duplicate .
- Status changed to RTBC
about 1 year ago 11:40pm 3 May 2023 - π―π΅Japan ptmkenny
I can confirm MR8 fixes this warning in PHP 8.2.
- Assigned to Grevil
- Status changed to Needs work
9 months ago 3:41pm 6 October 2023 - π©πͺGermany Anybody Porta Westfalica
I'd vote to make it protected, as if anyone needs to extend it, the __construct in the extending class won't work.
And from my perspective, the __construct also needs to be protected to have a correct factory pattern!We should use this chance to fix this and afterwards merge this fix!
@Grevil do you agree?
- Issue was unassigned.
- Assigned to Grevil
- Issue was unassigned.
- Status changed to Closed: duplicate
9 months ago 8:57am 10 October 2023 - π©πͺGermany Grevil
Already fixed through π Fix broken tests (D10.1) Active (and yes, we used "protected" there).