- Issue created by @nmangold
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.
- Status changed to Needs work
almost 2 years ago 5:37am 16 March 2023 - 🇮🇳India vishal.kadam Mumbai
1. Fix phpcs issue.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml highlightjs_input_filter/ FILE: highlightjs_input_filter/README.md ------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------ 5 | WARNING | Line exceeds 80 characters; contains 111 characters ------------------------------------------------------------------------
2. FILE: highlightjs_input_filter.info.yml
package: custom
Modules should avoid using this value for the package.
3. README.md file is missing a few required sections.
Please take a moment to make your README.md follow the guidelines.
- 🇮🇳India vishal.kadam Mumbai
Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage.
This project is too small for us and it doesn't contain enough PHP code to really assess your skills as a developer.
Have you made any other contributions that we could instead review?
- 🇮🇹Italy apaderno Brescia, 🇮🇹
To make the previous comment clearer: This application can continue only with another project.
- Status changed to Needs review
over 1 year ago 1:34pm 21 August 2023 - 🇺🇸United States nmangold United States
I have added more features to this module, including a module settings form, route, menu item. Also, the module is dynamically loading assets to optimize page load times.
Is this enough changes to consider? If not, please give me an example of the minimum amount of code to consider being approved.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
- Dries → ' post on Responsible maintainers
- Best practices for creating and maintaining projects →
- Maintaining a drupal.org project with Git →
- Commit messages - providing history and credit →
- Release naming conventions → .
- Helping maintainers in the issue queues →
You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.I thank all the reviewers.
- Assigned to apaderno
- Status changed to Fixed
about 1 year ago 11:19am 27 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.