- Issue created by @jurgenhaas
- @jurgenhaas opened merge request.
- Status changed to Needs review
almost 2 years ago 7:54am 14 March 2023 - Status changed to Needs work
almost 2 years ago 8:08am 14 March 2023 I didn't know how to deal with this situation so thank you very much for the MR.
I think I have to make a few changes though to:
- Handle the possibility of having multiple calendar fields selected
- Test against all possible date field types
I commented on the MR
- 🇩🇪Germany jurgenhaas Gottmadingen
@matthieuscarset I don't see any comments in the MR, so I'm going to respond here:
Handle the possibility of having multiple calendar fields selected
That may be tricky, or even impossible. What's the use case of having multiple date fields? For the SQL query filter it's important because we can't just do
WHERE date1>min AND date2>min AND date3>min ...
. So, if there are multiple data fields, what are the values of the other date fields then?Test against all possible date field types
Good you mention this. WRT
$alias = $calendarField->realField . '__value';
I wanted to mention that (but forgot) that this is what works with smart_date recurring values. I wish we could determine the value column dynamically but I honestly don't know how. - Assigned to matthieuscarset
Assigning this issue to myself as I need to seat down and test a few things before fixing/merging code.
Will come back here to comment and update status ASAP.
Thanks to your code and to the work on this other issue ✨ Add support for week calendar display Fixed , I have found out the right place to restrict the query to the current month.
It will be release soon - it depends on the other issue.
- Status changed to Fixed
over 1 year ago 7:14pm 23 March 2023 Code is merged on
2.0.x
.Will be shipped in new release
2.0.7
soon.-
matthieuscarset →
committed d8f82442 on 2.0.x
Fix filter conditions for multiple fields #3347793
-
matthieuscarset →
committed d8f82442 on 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇬🇧United Kingdom PQ
Correct me if I'm wrong, but this doesn't look like it ever made it into the 2.1.x branch, it got removed in https://git.drupalcode.org/project/calendar_view/-/commit/8fda28446b4b37..., unless I'm missing how it was implemented elsewhere.
- 🇬🇧United Kingdom PQ
Ignore this, I've just raised it as a new issue at https://www.drupal.org/project/calendar_view/issues/3491030 🐛 Slow render time Active .