Account created on 15 December 2010, about 14 years ago
#

Recent comments

πŸ‡¬πŸ‡§United Kingdom PQ

N.b. looks like the filtering code was removed in https://git.drupalcode.org/project/calendar_view/-/commit/8fda28446b4b37....

πŸ‡¬πŸ‡§United Kingdom PQ

Ignore this, I've just raised it as a new issue at https://www.drupal.org/project/calendar_view/issues/3491030 πŸ› Slow render time Active .

πŸ‡¬πŸ‡§United Kingdom PQ

pq β†’ created an issue.

πŸ‡¬πŸ‡§United Kingdom PQ

Correct me if I'm wrong, but this doesn't look like it ever made it into the 2.1.x branch, it got removed in https://git.drupalcode.org/project/calendar_view/-/commit/8fda28446b4b37..., unless I'm missing how it was implemented elsewhere.

πŸ‡¬πŸ‡§United Kingdom PQ

So I seem to have managed to unintentionally create a fork. Don't know if that's undoable.

Really sorry about that!

πŸ‡¬πŸ‡§United Kingdom PQ

PQ β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom PQ

Just a note that the current solution here seems to break when used with the sendgrid_integration module which validates the email addresses of the bcc and cc headers. If empty it throws an error.

It might be resolved by changing this:

      $data['to'] = implode(',', $recipients['to']);
      $data['params']['headers']['Cc'] = implode(',', $recipients['cc']);
      $data['params']['headers']['Bcc'] = implode(',', $recipients['bcc']);

(in src/Notification.php line ~213) to something like:

      $data['to'] = implode(',', $recipients['to']);
      if (!empty($recipients['cc'])) {
        $data['params']['headers']['Cc'] = implode(',', $recipients['cc']);
      }
      if (!empty($recipients['bcc'])) {
        $data['params']['headers']['Bcc'] = implode(',', $recipients['bcc']);
      }
πŸ‡¬πŸ‡§United Kingdom PQ

Appears to work fine, any chance of a commit (if only into dev) so it can play nicely with composer on D10 sites?

Production build 0.71.5 2024