[2.x] Bootstrap Italia

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

1. Fix PHPCS issues. You can use the PHPCS tool for checking and resolving issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml bootstrap_italia/

FILE: bootstrap_italia/CHANGELOG.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
  58 | WARNING | Line exceeds 80 characters; contains 83 characters
 100 | WARNING | Line exceeds 80 characters; contains 115 characters
 101 | WARNING | Line exceeds 80 characters; contains 111 characters
 137 | WARNING | Line exceeds 80 characters; contains 88 characters
 138 | WARNING | Line exceeds 80 characters; contains 100 characters
----------------------------------------------------------------------


FILE: bootstrap_italia/modules/bootstrap_italia_views_list/src/Plugin/views/style/ListStyle.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 49 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------


FILE: bootstrap_italia/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 177 | WARNING | Line exceeds 80 characters; contains 86 characters
 191 | WARNING | Line exceeds 80 characters; contains 81 characters
 349 | WARNING | Line exceeds 80 characters; contains 90 characters
 406 | WARNING | Line exceeds 80 characters; contains 104 characters
----------------------------------------------------------------------

2. Remove LICENSE file

The LICENSE file isn't necessary, since every project hosted on drupal.org is licensed under the same license used by Drupal core. That file is also automatically added from the packaging script.

phpstan issues
php -d memory_limit=4G ../../vendor/bin/phpstan analyse bootstrap_italia

------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   modules/bootstrap_italia_views_accordion/src/Plugin/views/style/AccordionStyle.php                                                                
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
  49     Parameter #2 $form_state (Drupal\core\form\FormStateInterface) of method                                                                          
         Drupal\bootstrap_italia_views_accordion\Plugin\views\style\AccordionStyle::buildOptionsForm() is not contravariant with parameter #2 $form_state  
         (Drupal\Core\Form\FormStateInterface) of method Drupal\views\Plugin\views\ViewsPluginInterface::buildOptionsForm().                               
  49     Parameter $form_state of method Drupal\bootstrap_italia_views_accordion\Plugin\views\style\AccordionStyle::buildOptionsForm() has invalid type    
         Drupal\core\form\FormStateInterface.                                                                                                              
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   modules/bootstrap_italia_views_carousel/src/Plugin/views/style/CarouselStyle.php                                                                
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------ 
  49     Parameter #2 $form_state (Drupal\core\form\FormStateInterface) of method                                                                        
         Drupal\bootstrap_italia_views_carousel\Plugin\views\style\CarouselStyle::buildOptionsForm() is not contravariant with parameter #2 $form_state  
         (Drupal\Core\Form\FormStateInterface) of method Drupal\views\Plugin\views\ViewsPluginInterface::buildOptionsForm().                             
  49     Parameter $form_state of method Drupal\bootstrap_italia_views_carousel\Plugin\views\style\CarouselStyle::buildOptionsForm() has invalid type    
         Drupal\core\form\FormStateInterface.                                                                                                            
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   modules/bootstrap_italia_views_gallery/src/Plugin/views/style/GalleryStyle.php                                                                
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------- 
  49     Parameter #2 $form_state (Drupal\core\form\FormStateInterface) of method                                                                      
         Drupal\bootstrap_italia_views_gallery\Plugin\views\style\GalleryStyle::buildOptionsForm() is not contravariant with parameter #2 $form_state  
         (Drupal\Core\Form\FormStateInterface) of method Drupal\views\Plugin\views\ViewsPluginInterface::buildOptionsForm().                           
  49     Parameter $form_state of method Drupal\bootstrap_italia_views_gallery\Plugin\views\style\GalleryStyle::buildOptionsForm() has invalid type    
         Drupal\core\form\FormStateInterface.                                                                                                          
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------------------- 
  Line   modules/bootstrap_italia_views_list/src/Plugin/views/style/ListStyle.php                                                                
 ------ ---------------------------------------------------------------------------------------------------------------------------------------- 
  49     Parameter #2 $form_state (Drupal\core\form\FormStateInterface) of method                                                                
         Drupal\bootstrap_italia_views_list\Plugin\views\style\ListStyle::buildOptionsForm() is not contravariant with parameter #2 $form_state  
         (Drupal\Core\Form\FormStateInterface) of method Drupal\views\Plugin\views\ViewsPluginInterface::buildOptionsForm().                     
  49     Parameter $form_state of method Drupal\bootstrap_italia_views_list\Plugin\views\style\ListStyle::buildOptionsForm() has invalid type    
         Drupal\core\form\FormStateInterface.                                                                                                    
 ------ ---------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------ 
  Line   modules/bootstrap_italia_views_timeline/src/Plugin/views/style/TimelineStyle.php                                                                
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------ 
  49     Parameter #2 $form_state (Drupal\core\form\FormStateInterface) of method                                                                        
         Drupal\bootstrap_italia_views_timeline\Plugin\views\style\TimelineStyle::buildOptionsForm() is not contravariant with parameter #2 $form_state  
         (Drupal\Core\Form\FormStateInterface) of method Drupal\views\Plugin\views\ViewsPluginInterface::buildOptionsForm().                             
  49     Parameter $form_state of method Drupal\bootstrap_italia_views_timeline\Plugin\views\style\TimelineStyle::buildOptionsForm() has invalid type    
         Drupal\core\form\FormStateInterface.                                                                                                            
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------ 

Thanks to vishal.kadam, apaderno and Rashmisoni for advice and help.

1. Fix PHPCS issues: bbdd40b9

2. Remove LICENSE file: eef9064d

3. Place css and js folders in the root directory instead of the src directory: c55cf3d2

4. phpstan issues: 7e9f53a2

Hello @arturopanetta,

I have reviewed the changes, and they look fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

Thanks

On the modules directory, there are .module files that contain just a comment. Drupal 8 modules do not need any .module file, to be recognized as modules. It is sufficient the .info.yml file.

Thanks @apaderno i removed the files with comments only

Automatically closed - issue fixed for 2 weeks with no activity.