Add option to load photoswipe.dev library

Created on 1 March 2023, almost 2 years ago
Updated 4 August 2023, over 1 year ago

Problem/Motivation

The photoswipe.dev library is defined in photoswipe.libraries.yml but never used. There's not even a switch for that.

As this is very rarely helpful, one can do it in the far future. We'll keep the library entry so, but don't use it currently.

Steps to reproduce

Proposed resolution

  • Provide an option on the Photoswipe settings page to switch between dev and live version (live is default)
  • in hook_library_alter switch the dependency from photoswipe to photoswipe.dev if dev mode is enabled

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Closed: won't fix

Version

5.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024