- Issue created by @Anybody
- Assigned to dinazaur
- last update
over 1 year ago Composer require failure - @dinazaur opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:34am 30 May 2023 - Status changed to Needs work
over 1 year ago 8:46am 30 May 2023 - π©πͺGermany Anybody Porta Westfalica
Thanks @dinazaur I left some comments. :)
- π©πͺGermany Anybody Porta Westfalica
And please add tests to show it works as expected now and in the future.
- last update
over 1 year ago 13 pass, 2 fail - Open on Drupal.org βCore: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Waiting for branch to pass - Status changed to Needs review
over 1 year ago 9:15am 30 May 2023 - πΊπ¦Ukraine dinazaur
There is no "dev" version of photoswipe library when installed via bower/npm assets. So we should change the target branch for 3.x, since 5.x will not include this functionality.
- Status changed to Closed: won't fix
over 1 year ago 10:35am 3 August 2023 - π©πͺGermany Anybody Porta Westfalica
@Grevil: I think it's not worth to implement new features in 4.x - so let's close this then... if someone needs it, this can be reopened with a MR.
- π©πͺGermany Anybody Porta Westfalica
@dinazaur or would you like to have this merged into 4.x (former 3.x)?
- πΊπ¦Ukraine dinazaur
Hi @Anybody, as this is a minor addition, and probably no one will use we can always re-open the issue again.