Entity diagram: Has repeated breadcrumb

Created on 1 March 2023, almost 2 years ago
Updated 9 March 2023, almost 2 years ago

Problem/Motivation

Best Practice: There is a duplicate breadcrumb:

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States swirt Florida

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

Sign in to follow issues

Comments & Activities

  • Issue created by @swirt
  • Assigned to dineshkumarbollu
  • 🇮🇳India dineshkumarbollu

    Hi swirt

    I will work on this issue.

  • @dineshkumarbollu opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • 🇮🇳India dineshkumarbollu

    Hi swirt

    I create a MR for this issue, The issue is due You are calling '_title_callback' in routing it is also calling in controller.If We remove this the menus will be proper i am attaching Screenshot how it will look now.

    Please review

    Thanks.

  • 🇺🇸United States swirt Florida

    Thank you dineshkumarbollu for your contribution. I am out of the office today but will look at this tomorrow.

  • 🇺🇸United States swirt Florida
  • 🇺🇸United States swirt Florida

    I don't think the solution your proposed is going to work dineshkumarbollu. My apologies for for creating this issue with a slightly misleading problem statement. This was created as a result of an accessibility review that did not identify that the second of the repeated breadcrumbs is supposed to be there.

    In looking at this closer,the defect is not that there is a repeated breadcrumb, but they appear to be repeated because they have the same name for different paths.
    /admin/reports/content-model/entity-diagram is the first one
    /admin/reports/content-model/entity-diagram/node is the second.

    So they should both be there, but the second one should have a more meaningful name since it represents the bundle.
    Entity Relationship Diagram - first one
    Entity type name - second one.

    Examples:
    Home >> Administration >> Reports >> Content Model >> Entity Relationship Diagram >> Node
    Home >> Administration >> Reports >> Content Model >> Entity Relationship Diagram >> Paragraph
    Home >> Administration >> Reports >> Content Model >> Entity Relationship Diagram >> Taxonomy

  • 🇺🇸United States swirt Florida

    Sorry for my confusion. I see that your patch actually achieves what I just described as desired. Testing it further now.

  • 🇺🇸United States swirt Florida

    Tested by me and it works great. Thank you so much for solving this.

  • Status changed to RTBC almost 2 years ago
  • Status changed to Fixed almost 2 years ago
  • 🇺🇸United States swirt Florida
  • Status changed to Fixed almost 2 years ago
  • 🇺🇸United States swirt Florida
  • 🇺🇸United States swirt Florida

    This fix will go out with release 1.0.2

    Thank you @flanneryla for finding the problem.
    Thank you @dineshkumarbollu for fixing the problem. Well done.

Production build 0.71.5 2024