TypeError: Drupal\color_field\ColorHex::__construct(): Argument #2 ($opacity) must be of type ?string, int given

Also removed the return value in the constructor.

Updated the MR because the opacity can also be NULL and in PHP 8.1 that needs to be declared accordingly.

Thanks for the proposed solution and PR, hopefully these will be accepted soon. Run into the same problem with php 8.1, attaching quick fix patch with casting $item->opacity to string value.

Hi jurgenhaas,

I confirmed the issue was resolved when I applied patch #5 to the "Color Field" against Version
3.0.x-dev. Please look at the screenshots attached.

For your review.
Thank you.

I applied this patch, but when setting the field formatting to Color CSS declaration and trying to save the settings with layout_builder enabled, the error still occurs.

I wrote working patch for this issue.

The last submitted patch, 8: color_field-opacity_wrong_type-3344907-8.patch, failed testing. View results →

I forgot modified also `ColorFieldFormatterCss.php` file. Now should be okay in layout_builder display and on page.

RTBC for the MR changes.

I was a little hasty in marking as RTBC and didn't test sufficiently. Seems like when loading the entity to be viewed, the opacity value returned from DB is a string, so there are errors with the formatters:

The website encountered an unexpected error. Please try again later.
TypeError: Drupal\color_field\ColorHex::__construct(): Argument #2 ($opacity) must be of type ?float, string given, called in /var/www/html/web/modules/contrib/color_field/src/Plugin/Field/FieldFormatter/ColorFieldFormatterText.php on line 131 in Drupal\color_field\ColorHex->__construct() (line 30 of modules/contrib/color_field/src/ColorHex.php).
Drupal\color_field\ColorHex->__construct('#EC1818', '0.7') (Line: 131)
Drupal\color_field\Plugin\Field\FieldFormatter\ColorFieldFormatterText->viewValue(Object) (Line: 81)

OK, so it looks like, depending on context, the opacity value passed to the ColorHex constructor can be NULL, float/int, or string.

• When loading opacity value from DB to view in formatter, value is string
• When editing a paragraph with color field in Layout Paragraphs builder, the opacity will be a float
• When editing default layout of content type with a color field, opacity can be a int

One simple way would be to use a union type hint of ?string|float, but that is PHP 8+ only.

I wonder if there's a core issue to cast values to float when retrieved from DB storage for fields of type float (or similarly for any other fields).

Anyway, for now:
Pushed a commit to the MR to cast opacity to the right value before passing into Constructor in the formatters and in the module file.

@godotislate your latest commit to the MR looks great and should solve all possible issues.

MR looks good and fixes the issue for me.

Thanks

Patch #9 updated to Drupal 10 context, apply the same guarantee to #1 parameter.

Generate a patch with the solution proposed on the merge request Compatible with D10 php 8.1

Rerolled patch #17 is working for me.

patch #17 is working for me too - thanks!

Thanks for everyone's work on this issue. I was able to reproduce the problem, and verify that the patch in #17 resolved it. Merged in.

Automatically closed - issue fixed for 2 weeks with no activity.