Fix the issues reported by phpcs

Created on 23 February 2023, almost 2 years ago
Updated 15 March 2023, over 1 year ago

Problem/Motivation

There are a number of PHPCS issues being reported during automated tests.

Proposed resolution

Resolve outstanding PHPCS issues.

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States markdorison

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @markdorison
  • @markdorison opened merge request.
  • Status changed to Needs review almost 2 years ago
  • 🇮🇳India nayana_mvr

    Verified MR!17. Except the following issues, all other errors are fixed:

    FILE: ../contrib/csv_serialization/README.md
    -----------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------
     49 | WARNING | Line exceeds 80 characters; contains 86 characters
    -----------------------------------------------------------------------------------------------
    
    
    FILE: ../contrib/csv_serialization/csv_serialization.install
    ---------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
    ---------------------------------------------------------------------------------------------------------------
      1 | ERROR   | [x] Missing file doc comment
      5 | ERROR   | [ ] Missing short description in doc comment
     12 | WARNING | [ ] Hook implementations should not duplicate @param documentation
     12 | ERROR   | [ ] Missing parameter comment
     12 | ERROR   | [ ] Missing parameter type
     14 | WARNING | [ ] Hook implementations should not duplicate @return documentation
     14 | ERROR   | [ ] Description for the @return value is missing
    ---------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ---------------------------------------------------------------------------------------------------------------
    
    Time: 222ms; Memory: 12MB
    
  • First commit to issue fork.
  • @annmarysruthy opened merge request.
  • Status changed to Needs work over 1 year ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India mrinalini9 New Delhi

    Rerolled patch #21, please review it.

    Thanks!

    • markdorison committed 38efd021 on 3.x
      Issue #3344114 by markdorison, imustakim, Akram Khan, annmarysruthy,...
  • Status changed to Fixed over 1 year ago
  • 🇺🇸United States markdorison

    In the future, if an issue has been started with a merge request, I encourage you to stick with that instead of switching to using patch files.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024