- Issue created by @markdorison
- @markdorison opened merge request.
- Status changed to Needs review
almost 2 years ago 9:31pm 23 February 2023 - 🇮🇳India nayana_mvr
Verified MR!17. Except the following issues, all other errors are fixed:
FILE: ../contrib/csv_serialization/README.md ----------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------- 49 | WARNING | Line exceeds 80 characters; contains 86 characters ----------------------------------------------------------------------------------------------- FILE: ../contrib/csv_serialization/csv_serialization.install --------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 5 | ERROR | [ ] Missing short description in doc comment 12 | WARNING | [ ] Hook implementations should not duplicate @param documentation 12 | ERROR | [ ] Missing parameter comment 12 | ERROR | [ ] Missing parameter type 14 | WARNING | [ ] Hook implementations should not duplicate @return documentation 14 | ERROR | [ ] Description for the @return value is missing --------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------- Time: 222ms; Memory: 12MB - First commit to issue fork.
- @annmarysruthy opened merge request.
- Status changed to Needs work
almost 2 years ago 11:45am 4 March 2023 - Status changed to Needs review
almost 2 years ago 11:50am 9 March 2023 - 🇮🇳India mrinalini9 New Delhi
Rerolled patch #21, please review it.
Thanks!
-
markdorison →
committed 38efd021 on 3.x
Issue #3344114 by markdorison, imustakim, Akram Khan, annmarysruthy,...
-
markdorison →
committed 38efd021 on 3.x
- Status changed to Fixed
almost 2 years ago 1:40pm 15 March 2023 - 🇺🇸United States markdorison
In the future, if an issue has been started with a merge request, I encourage you to stick with that instead of switching to using patch files.
Automatically closed - issue fixed for 2 weeks with no activity.