Update CKEditor 5 to 36.0.1

The last submitted patch, 2: 3344083-2.patch, failed testing. View results →

The patch worked for me.

I've made new tests locally.
Both patches on #2 📌 Update CKEditor 5 to 36.0.1 Fixed and #5 📌 Update CKEditor 5 to 36.0.1 Fixed work.

On #5 it is for CK editor 36.0.1.

+++ b/core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaTest.php
@@ -1599,7 +1599,10 @@ public function testViewMode(bool $with_alignment) {
+    $this->assertNotEmpty($dropdown = $this->getBalloonButton('View Mode 1'));
...
     $this->assertNotEmpty($this->getBalloonButton('View Mode 1'));

This looks to fix the test fail from #2, but isn't this just asserting the same thing twice now?

@longwave I'm reading it as

Is it visible
Is it not empty, guess this could be valid as maybe its visible but empty?

Certainly seems like additional coverage but not sure it's 100% the same thing. Could very well be wrong.

I added the assertNotEmpty before clicking just to have better error messages in case the button doesn't exist. We could potentially remove the second assertion but I don't see any harm asserting that the button exists after the dropdown tray has been opened. It also makes it clear that we expect three buttons to exist there.

Patch for 9.5.x.

Committed/pushed to 10.1.x, cherry-picked to 10.0.x, and committed the 9.5.x patch to 9.5.x, thanks!

Woah, I did not know this was going to land in Drupal 9.5 & 10.0 too! That's why in #8 I specifically tagged it 10.1.0 release notes… 😅

I thought our policy was to keep every Drupal core minor on the same CKEditor 5 major, and only update to CKEditor 5 minor/patch releases (which indeed are very rare)?

CKEditor 5 major releases introduce BC breaks. And this is not theoretical, e.g. contrib modules are breaking due to this: 📌 LinkIt requires new minor version for Drupal 10.1.x, since CKEditor 5 got a major version update (v35 → v36) Fixed . Contrib modules providing custom CKEditor 5 plugins will often (but not always) have to create a new minor release specifically for the next core minor to chase this. It will often be as simple as re-building using yarn, but it's still necessary.

IMHO we should revert this commit in 9.5.x and 10.0.x and unpublish the 9.5.6 and 10.0.6 releases, and redo them without this one commit. 😬🙈

Pretty sure releases can't be unpublished but this may be justification for a narrowly-focused minor version release?

I've reverted this. Probably a good idea to put '10.1.x only' in the issue summary for ckeditor major updates.

I don't think we need to unpublish those releases, but we should do new ones. I'm short on time this afternoon so not sure I can get to those today.

Back to fixed for 10.1.0

@bradjones1 there's a minor release in June, so it's not long to wait for the new ckeditor5 major.

Automatically closed - issue fixed for 2 weeks with no activity.