- Issue created by @Summit
- Status changed to Needs review
almost 2 years ago 10:14am 23 February 2023 - Status changed to Postponed
almost 2 years ago 11:13pm 23 February 2023 - ๐ฎ๐ฉIndonesia gausarts
Thank you.
Task for any upstream breaking changes.
We'll need to fix it once for the entire ecosystem. Please move your patch to Blazy as mentioned here:
https://www.drupal.org/project/splide/issues/3338709#comment-14904569 ๐ Deprecated function: Creation of dynamic property Fixed - ๐ช๐ธSpain tar_inet
Patch #2 works for me.
@gausarts
BlazyFilterBase
uses$blazyAdmin
as property and its type is\Drupal\blazy\Form\BlazyAdminInterface
(https://git.drupalcode.org/project/blazy/-/blob/8.x-2.x/src/Plugin/Filte...) meanwhileSlickFilter
uses $admin
with type\Drupal\slick\Form\SlickAdminInterface
.Seen these differences I donยดt think itยดs an easy change to be made in Blazy without breaking something else.
- ๐ฎ๐ฉIndonesia gausarts
No problem at all, 100% :)
It is only registering the property. Properties can be overriden just as classes or even services.
$blazyAdmin
is already reserved by Blazy. We left it as is.
$admin
is always open, generic, for any sub-modules. Blazy diesn't care nor use it. It just provides it quickly to DRY for many of its sub-modules since updating each sub-modules for the exact same change may take more time and energy.The same patterns can be seen anywhere else:
$blazyManager
for Blazy,$manager
for its sub-modules, etc.Let me know if anything else?
Please move your patch to Blazy as mentioned in the above link. Just change
@var
to says\BlazyFilterInterface
.Thanks.
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Same issue here filling up the logs. Did anyone already create that issue / patch at Blazy?
- Status changed to Fixed
over 1 year ago 10:02am 15 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.