- Issue created by @sahil.goyal
- Status changed to Needs review
about 2 years ago 4:07am 22 February 2023 - 🇮🇳India sahil.goyal
Fixing all minor phpcs issues/warnings. Please review.
- Status changed to RTBC
about 2 years ago 5:05am 22 February 2023 - 🇮🇳India Ranjit1032002
I had Reviewed the patch and it's working as expected mentioned in comment #2
- First commit to issue fork.
- @urvashi_vora opened merge request.
- Status changed to Needs work
about 2 years ago 5:18am 2 March 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ if ($form_object instanceof + ConfigFormBase || $form_object instanceof + FieldConfigEditForm) {
The class name to which
instanceof
is referring should not go in a new line; those spaces before||
are not necessary, - 🇮🇹Italy apaderno Brescia, 🇮🇹
Also, it seems pointless to create a MR that contains the same changes the existing patch contains.
- First commit to issue fork.
- Status changed to Needs review
about 2 years ago 5:57am 2 March 2023 - Status changed to Needs work
over 1 year ago 7:13pm 20 September 2023 - 🇺🇸United States mlncn Minneapolis, MN, USA
Thanks, the underlying code changed a bit (sorry) but this suggested an improvement there too so crediting.
- Status changed to Fixed
over 1 year ago 7:15pm 20 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.