- Issue created by @omkar_yewale
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:12am 21 February 2023 The last submitted patch, 2: 3343292-2-coding-standard.patch, failed testing. View results ā
- Assigned to annmarysruthy
- Status changed to Needs work
over 1 year ago 4:43am 21 February 2023 - Merge request !10Issue #3343292: Drupal Coding Standards Issues | phpcs ā (Open) created by annmarysruthy
- @annmarysruthy opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:31am 21 February 2023 - š®š³India annmarysruthy
Created an MR to solve phpcs issues as patch #3 failed. Please review MR !10.
- Status changed to RTBC
3 months ago 10:38am 15 August 2024 - šµšPhilippines cleavinjosh
Hi @annmarysruthy,
I applied MR!10, it was applied smoothly and fixed the phpcs issue.
ā contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml welcome_mail FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/welcome_mail/welcome_mail.module ----------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------- 10 | WARNING | Global constants should not be used, move it to a class or interface ----------------------------------------------------------------------------------------------------- Time: 323ms; Memory: 10MB ā contrib cd welcome_mail ā welcome_mail git:(8.x-1.x) curl https://git.drupalcode.org/project/welcome_mail/-/merge_requests/10.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1204 0 1204 0 0 2518 0 --:--:-- --:--:-- --:--:-- 2518 patching file welcome_mail.module ā welcome_mail git:(8.x-1.x) ā .. ā contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml welcome_mail ā contribThank you.
- First commit to issue fork.
- Status changed to Postponed: needs info
3 months ago 7:02pm 18 August 2024 - š³š“Norway eiriksm Norway
Thanks alot for working on this module!
Hm, but I don't understand why this was opened?
Here is a link to the latest run of PHPCS of this module: https://git.drupalcode.org/project/welcome_mail/-/jobs/1148628
It has no errors.
This MR does not have any coding styles either, but it has issues, for example:
- A class defined in a module file
- A constant removed that people might depend onClosing for now, please reopen if I am misunderstanding the intent.