- Issue created by @aaron.ferris
- Status changed to Needs review
almost 2 years ago 11:45am 20 February 2023 - Status changed to RTBC
almost 2 years ago 3:53pm 22 February 2023 - 🇬🇧United Kingdom progga
I can confirm that the patch from #3 works for me. Thanks a lot for the fix :)
- 🇬🇧United Kingdom progga
Additionally, this new `require` option introduced in #3070519 → is missing a config schema definition. I am not sure if that should be bundled with this fix. Something like this resolves both issues:
diff --git a/modules/search_api_location_views/config/schema/search_api_location_views.schema.yml b/modules/search_api_location_views/config/schema/search_api_location_views.schema.yml index e110ba7..934ec85 100644 --- a/modules/search_api_location_views/config/schema/search_api_location_views.schema.yml +++ b/modules/search_api_location_views/config/schema/search_api_location_views.schema.yml @@ -98,6 +98,9 @@ views.filter.search_api_location: to: type: string label: 'Distance to' + require: + type: boolean + label: 'Does it require successfull location resolving?' views.filter_value.search_api_location: diff --git a/modules/search_api_location_views/src/Plugin/views/filter/SearchApiFilterLocation.php b/modules/search_api_location_views/src/Plugin/views/filter/SearchApiFilterLocation.php index f1a7491..ff24b6f 100644 --- a/modules/search_api_location_views/src/Plugin/views/filter/SearchApiFilterLocation.php +++ b/modules/search_api_location_views/src/Plugin/views/filter/SearchApiFilterLocation.php @@ -85,7 +85,7 @@ class SearchApiFilterLocation extends FilterPluginBase { ], ]; - $options['require'] = FALSE; + $options['require'] = ['default' => FALSE]; return $options; }
-
JeroenT →
committed 132116e6 on 8.x-1.x authored by
aaron.ferris →
Issue #3343143 by aaron.ferris, progga, rckstr_rohan, JeroenT: PHP...
-
JeroenT →
committed 132116e6 on 8.x-1.x authored by
aaron.ferris →
- Status changed to Fixed
almost 2 years ago 1:09pm 23 February 2023 - 🇧🇪Belgium JeroenT 🇧🇪
Opened a follow-up issue for the config schema: 🐛 Missing config schema for search_api_location require option Needs review
Automatically closed - issue fixed for 2 weeks with no activity.