- Issue created by @omkar_yewale
- Issue was unassigned.
- Status changed to Needs work
about 2 years ago 3:05am 20 February 2023 - Status changed to Needs review
about 2 years ago 3:06am 20 February 2023 - Merge request !1Issue #3343040: Drupal Coding Standards Issues | phpcs → (Open) created by omkar_yewale
- 🇮🇳India rckstr_rohan
Reviewed the MR, working fine and phpcs issue fixed.
- 🇮🇳India dev16.addweb
silvi.addweb → made their first commit to this issue’s fork.
- 🇮🇳India dev16.addweb
Fixed the below-mentioned issues of phpcs. Also raised MR for the same.
FILE: /home/addweb/Drupal8-vagrant/web/web/patches/dark_mode_switch-3343040/README.md ------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------- 20 | WARNING | Line exceeds 80 characters; contains 89 characters ------------------------------------------------------------------------------------- FILE: /home/addweb/Drupal8-vagrant/web/web/patches/dark_mode_switch-3343040/src/Plugin/Block/DarkModeSwitch.php --------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------- 42 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 10 43 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 10 --------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------- FILE: /home/addweb/Drupal8-vagrant/web/web/patches/dark_mode_switch-3343040/src/Form/DarkModeSwitchSettings.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /home/addweb/Drupal8-vagrant/web/web/patches/dark_mode_switch-3343040/src/Theme/DarkModeSwitchTheme.php -------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\AdminContext. -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------