Fix the issues reported by phpcs

Open on Drupal.org →

Created on 16 February 2023, almost 2 years ago

Updated 22 February 2023, almost 2 years ago

FILE: /var/www/html/contribution/web/modules/contrib/events_log_track/event_log_track.install
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
136 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/events_log_track/css/event_log_track.admin.css
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
5 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/events_log_track/modules/event_log_track_ui/event_log_track_ui.module
--------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
5 | ERROR | [x] Doc comment short description must end with a full stop
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/events_log_track/modules/event_log_track_ui/src/OverviewForm.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------
290 | WARNING | [ ] User::load calls should be avoided in classes, use dependency injection instead
291 | ERROR | [x] Expected newline after closing brace
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/events_log_track/modules/event_log_track_config/src/EventSubscriber/EventLogTrackConfigSubscriber.php
----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------
52 | WARNING | Only string literals should be passed to t() where possible
----------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/events_log_track/modules/event_log_track_syslog/event_log_track_syslog.module
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
17 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "event_log_track_form_system_logging_settings_alter" but expected
| | "event_log_track_syslog_event_log_track_form_system_logging_settings_alter"
83 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "event_log_track_logging_settings_submit" but expected
| | "event_log_track_syslog_event_log_track_logging_settings_submit"
95 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "event_log_track_token_info" but expected
| | "event_log_track_syslog_event_log_track_token_info"
153 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "event_log_track_tokens" but expected
| | "event_log_track_syslog_event_log_track_tokens"
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/events_log_track/modules/event_log_track_tfa/event_log_track_tfa.module
----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/events_log_track/event_log_track.module
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------

📌 Task

Status

Fixed

Version

3.1

Component

Code

Created by

🇮🇳India himanshu_jhaloya Indore

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @himanshu_jhaloya
@himanshu_jhaloya opened merge request.
Status changed to Needs review almost 2 years ago7:36am 16 February 2023
Comment almost 2 years ago →
🇮🇳India himanshu_jhaloya Indore
Comment almost 2 years ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Needs work almost 2 years ago9:15pm 16 February 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
FYI I'm typically against tickets like these for my modules as they are credit farming and bot like. 9 of 10 times will close out as won't fix. If you wish to truly contribute I would recommend addressing bugs and issues.

But there may be some value on this particular one.

What tests did you do for this though?
Comment almost 2 years ago →
🇺🇸United States smustgrave
Comment almost 2 years ago →
🇦🇺Australia mingsong 🇦🇺
smustgrave → credited Mingsong → .
Status changed to Fixed almost 2 years ago3:30pm 22 February 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024