Fix the issues reported by phpcs

FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/tests/src/Functional/EntityOperationsTest.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 1 WARNING AFFECTING 5 LINES --------------------------------------------------------------------------------------------------------------------------------- 65 | ERROR | [ ] Parameter tags must be defined first in a doc comment 65 | ERROR | [ ] Missing parameter type 67 | ERROR | [ ] Missing parameter type 78 | ERROR | [ ] Type hint "array" missing for $permissions 78 | ERROR | [ ] Type hint "array" missing for $modules 86 | ERROR | [x] There should be no white space after an opening "(" 94 | WARNING | [ ] Unused variable $group. --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/tests/src/Kernel/GroupMediaConfigTest.php ----------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------- 27 | WARNING | [x] A comma should follow the last multiline array item. Found: 'views' ----------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/groupmedia.module ----------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------- 14 | WARNING | [x] Unused use statement 107 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/modules/groupmedia_paragraphs/groupmedia_paragraphs.module ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 37 | WARNING | [x] '@TODO: Fix when the parent paragraph was not yet saved.' should match the format '@todo Fix problem X here.' ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/modules/groupmedia_vbo/src/Plugin/Action/RemoveMediaFromGroup.php ----------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------------- 77 | ERROR | [x] Expected 1 blank line after function; 0 found ----------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Form/GroupMediaSettingsForm.php ----------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 15 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ----------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/Group/Relation/GroupMediaDeriver.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 14 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/Group/RelationHandler/GroupMediaOperationProvider.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------- 42 | WARNING | [ ] MediaType::load calls should be avoided in classes, use dependency injection instead 49 | WARNING | [x] A comma should follow the last multiline array item. Found: pluginId ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/MediaFinder/TextFieldEmbedBase.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------------- 15 | WARNING | The class short comment should describe what the class does and not simply repeat the class name 83 | WARNING | Line exceeds 80 characters; contains 81 characters --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/MediaFinder/MediaReference.php ----------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------- 29 | WARNING | Line exceeds 80 characters; contains 81 characters ----------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/MediaFinder/MediaFinderBase.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 18 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/Plugin/Action/RemoveMediaFromGroup.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------ 76 | ERROR | [x] Expected 1 blank line after function; 0 found ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/AttachMediaToGroup.php ---------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES ---------------------------------------------------------------------------------------------------------------------- 21 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 124 | ERROR | [x] Expected 1 spaces after parameter type; 9 found 126 | ERROR | [x] Expected 1 spaces after parameter type; 2 found 128 | ERROR | [x] Expected 1 spaces after parameter type; 35 found 193 | ERROR | [x] Expected newline after closing brace 196 | ERROR | [x] Expected newline after closing brace 247 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 ---------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/groupmedia/src/MediaFinderInterface.php ----------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ----------------------------------------------------------------------------------------------------------------- Time: 291ms; Memory: 10MB

Comments & Activities

Issue created by @sahil.goyal
Status changed to Needs review over 1 year ago4:51am 16 February 2023
Comment over 1 year ago →
🇮🇳India sahil.goyal
Updating the patch to resolve all php coding standards issues and warnings. Please Review.
Assigned to spriya2896
Comment over 1 year ago →
🇮🇳India spriya2896
I will review this patch.
Issue was unassigned.
Status changed to Needs work over 1 year ago5:41am 16 February 2023
Comment over 1 year ago →
🇮🇳India spriya2896
This patch failed to apply.
Assigned to annmarysruthy
Comment over 1 year ago →
annmarysruthy
@annmarysruthy opened merge request.
Issue was unassigned.
Status changed to Needs review over 1 year ago7:42am 16 February 2023
Comment over 1 year ago →
annmarysruthy
Created an MR for fixing the issue. please review.
@annmarysruthy opened merge request.
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Comment 10 months ago →
System Message

LOBsTerr → committed 56e3bcd1 on 8.x-2.x authored by sahil.goyal →
Issue #3342229 by sahil.goyal, LOBsTerr: Fix the issues reported by...
Comment 10 months ago →
System Message

LOBsTerr → committed 09114a0d on 3.0.x authored by sahil.goyal →
Issue #3342229 by LOBsTerr: Fix the issues reported by phpcs
Comment 10 months ago →
System Message

LOBsTerr → committed 45e07744 on 4.0.x authored by sahil.goyal →
Issue #3342229 by LOBsTerr: Fix the issues reported by phpcs
Status changed to Fixed 10 months ago2:18pm 5 September 2023
Comment 10 months ago →
🇧🇪Belgium LOBsTerr
Thank you for your contribution
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities