Rename validator methods to `validate` unless there different methods for different events

I think this is what @tedbow wanted 👍

@tedbow: what do you think about just naming all of these methods validate()? The specifics are already captured by the class name IMHO…

@tedbow: what do you think about just naming all of these methods validate()? The specifics are already captured by the class name IMHO…

I can see just having the same for the method. but if we are going to do that than maybe validateStagePreOperation is actually correct because all the event that use these methods extend `PreOperationStageEvent` or maybe just validatePreOperation

But maybe that is redundant we can only validate in `PreOperationStageEvent` post events don't have addError or addWarning.

So yes lets go with validate

Updated summary

Sorry for changing the scope @yash.rode

I have a doubt about the summary, correct me if I am wrong, if there is only one method and subscribed to 1 or more events then that should be renamed to validate() in other case(if the validator has multiple methods) it should be renamed to class specific name.

assigning to confirm my doubt in previous comment.

#9: Yep, that sounds right! But I don't see any such case? What am I missing? 🙈

I was going to RTBC but then I found several cases that have not yet been updated:

1. ComposerJsonExistsValidator
2. ComposerMinimumStabilityValidator
3. ComposerPatchesValidator
4. DuplicateInfoFileValidator
5. LockFileValidator
6. StageNotInActiveValidator
7. SupportedReleaseValidator

#11 📌 Rename validator methods to `validate` unless there different methods for different events Fixed : LockFileValidator is the case I am talking about, changed other method names.

@yash.rode the methods for that validator are:

  public static function getSubscribedEvents(): array {
    return [
      PreCreateEvent::class => 'storeHash',
      PreRequireEvent::class => 'validateStagePreOperation',
      PreApplyEvent::class => 'validateStagePreOperation',
      StatusCheckEvent::class => 'validateStagePreOperation',
      PostDestroyEvent::class => 'deleteHash',
    ];
  }

There's only one validation method, the two others do other things than validating. So those should remain unchanged.

Thanks to the latest commit, this is 99% done — only LockFileValidator still needs to be updated 👍

Perfect! 👍

Merged!

Automatically closed - issue fixed for 2 weeks with no activity.