Finalize \Drupal\automatic_updates\Development\Converter script to update core MR

Added to 🌱 Drupal 10 Core Roadmap for Automatic Updates Active 👍

Failed asserting that file "/var/www/html/core/modules/auto_updates/tests/src/Functional/../../../package_manager/tests/fixtures/release-history/drupal.9.8.2.xml" exists.

is wrong. Because it assumes that the package_manager module still lives inside of the auto_updates module, which it does not.

Also spotted 2 harmless obsolete things in the Converter and one actual bug.

🐛 Fix PHPStan violations (happened because PHPStan code checks stopped running…) Fixed is green and will soon be merged. That will allow you to remove the hack to avoid PHPStan complaints. 👍

Yesterday you had a proposal for how to deal with #8.1. I can't remember it though. Can you write it here?

Finally: my work on cspell in 📌 Stop reusing core's commit-code-check.sh in favor of 4 simple commands Fixed has made it clear that we actually need two dictionary.txts, one for each module — because the core MR will be for package_maanger only.

🐛 Fix PHPStan violations (happened because PHPStan code checks stopped running…) Fixed also landed! This now can definitely move forward.

After a failed attempt, do this in the core checkout: rm -rf core/modules/package_manager && git checkout -- core && cd core && yarn install && cd ..

Let's see if the new MR is green: #2977515-291: [ignore] Test Package manager core merge → — test results at https://www.drupal.org/pift-ci-job/2608719 → 😬.

eagerly awaiting results of:

• https://www.drupal.org/pift-ci-job/2614581 → → core + package_manager as of 1 week ago
• https://www.drupal.org/pift-ci-job/2614583 → → core + package_manager as of today

👆

That takes ~1 hour to run, I’m going for a run in the mean time. Assuming that’s green, I’ll take those results and transplant them onto ✨ Add Alpha level Experimental Package Manager module Needs review , and then we should a true green core MR! 🤓

Oops 😅 This is what I meant to do!

Awaiting resuls…

Ugh, the March 3 one passed thanks to @tedbow's fixes … but he didn't push them up to this branch! 😬 For example:

$ git show 1cb2443a09a8c6b558bdb3baeb1023b1fedef78a
commit 1cb2443a09a8c6b558bdb3baeb1023b1fedef78a
Author: Ted Bowman <ted+git@tedbow.com>
Date:   Tue Mar 7 12:32:24 2023 -0500

    Contrib: replace core_version_requirement - https://git.drupalcode.org/project/automatic_updates/-/commit/a39a545c9f9e0acf92535b7216bfd852f9f7dad1

… and on that note, it looks like he actually had already solved what I just fixed in a different way: https://git.drupalcode.org/project/drupal/-/merge_requests/3578/diffs?co... … ← also not pushed 😢

So I'm going to update the core MR at 3346707 manually, rather than spending more time on a Friday night re-creating what @tedbow already has working locally…

BTW, there are a few more things that should not be added to Drupal core, such as package_manager_update_9001(). I suggest we add the necessary

// BEGIN: DELETE FROM CORE MERGE REQUEST

and

// END: DELETE FROM CORE MERGE REQUEST

comments in this MR too, so that once this MR is merged, we're 100% satisfied with the MR it generates.

@Wim Leers, this MR should be green and I used it to convert the module to this green core merge request https://www.drupal.org/project/drupal/issues/3346707#mr3608-note158604 ✨ Add Alpha level Experimental Package Manager module Needs review on ✨ Add Alpha level Experimental Package Manager module Needs review

I created 🐛 ComposerFixtureCreator need to move and updated for core merge request Closed: duplicate as a follow-up. I think this could be a beta-target

Looking great! But I don't think I agree with #18. Quoting what I wrote at #3347937-3: ComposerFixtureCreator need to move and updated for core merge request → :

Are you saying it would be okay to not have the fixture creator in the MR at ✨ Add Alpha level Experimental Automatic Updates module Needs work ? I very much doubt that. That'd mean core requires some contrib script? 😅

IMHO this is something that is in the scope of 📌 Finalize \Drupal\automatic_updates\Development\Converter script to update core MR Fixed to fix?

And I think this should also do 📌 Add Composer Stager to Core vendor hardening config Active , since there's no point to do it as a separate issue.

Merged the current MR in to 3.0.x so we have an easy way to convert 3.0.x to the core merge request.

pre #19 I will close [#14967828] as a duplicate and we need to make another MR for that in this issue and add the scope to the summary

chatted with @catch https://drupal.slack.com/archives/C7QJNEY3E/p1678889303046529?thread_ts=...

Just going to move ComposerFixtureCreator into core/scripts.

This now moves PackageManagerFixtureCreator to core/scripts.

Assigning to @Wim Leers to review
To test:

1. After you run the conversion you can run php ./core/scripts/PackageManagerFixtureCreator.php from the base of core clone you are converting into.
2. If you git diff you should only see "reference": changes in core/modules/package_manager/tests/fixtures/fake_site

when these changes are good I suggest we merge the current changes into 3.0.x again. We can keep this issue open because we will likely have little changes we need to make to the conversion script until we are done using it.

@Wim Leers re https://git.drupalcode.org/project/automatic_updates/-/merge_requests/78...
I undid some changes I made to replace all static:: with self:: in the PackageManagerFixtureCreator. It made the diff much bigger.

We should probably fix this here though to consistent before the file is in core. But figured you can review only the needed changes first. If you want to merge these changes feel free, can also do the replacement static:: with self:: in the PackageManagerFixtureCreator if you want

#25: nice!

#26: once core MR is green including the fixture creator, I don't think is necessary — we can just commit whatever changes we need directly without the need for an issue IMHO — the commit message should just explain what we're doing. Because none of those commits would be making semantical changes to the logic of Package Manager itself, only to the script. And the script is just a tool to bring it into core, not an essential part of the module — issue queue hygiene/git archeology is pretty much non-important for it!

#27: self vs static in the context of this stand-alone script … is super unimportant IMHO 🥸

This looks great now! I trust that this results in a working core MR because adding a script cannot affect the test outcome. So … merged 🚢

Automatically closed - issue fixed for 2 weeks with no activity.