<i> (iconfont icon) wrapped into <em> with "Full HTML"

Is this intrinsic to Drupal or is it CKEditor behavior?

Seems to be Drupal-specific!

https://ckeditor.com/docs/ckeditor5/latest/features/source-editing.html
Trying that here leads to expected results:

<p>
    <i class="fa fa-drupal">Drupal</i>
</p>

1. Is this reproducible in if you explicitly allow <i>?
2. Any chance you could write a test for this? 🙏 😊

This is related to 🐛 [upstream] [GHS] CKEditor 5 removes empty inline elements Fixed but is definitely a different problem.

I'm 99% certain this is caused by DrupalEmphasisEditing — see core/modules/ckeditor5/js/ckeditor5_plugins/drupalEmphasis/src/drupalemphasisediting.js.

Any chance you could write a test for this? 🙏 😊

I'd very much like to, but currently missing spare time. I'll add an entry for our team, hopefully someone has some time to do it. Do you know a similar example to copy as a quick start? Especially for the CKEditor setup and interaction? That would speed things up a lot, I think.

I'll also ask to test 2. but if ANYONE coming here can do it, please do it and don't wait!

Thank you!

Actually, 99% of what you need is already provided by \Drupal\Tests\ckeditor5\FunctionalJavascript\EmphasisTest — you just want to explicitly test with .

Basically, you want to copy \Drupal\Tests\ckeditor5\FunctionalJavascript\EmphasisTest::testEmphasis(), rename it testEmphasisWithoutFilterHtml() and modify the text format config entity's filter_html to be disabled. That should reproduce it 🤓

I think that'll help you get started! 🤞

we also facing a similar issue on Ckeditor5 and would like to know a fixed solution. Do we've to downgrade it to 1 version means Ckeditor4?

@Wim Leers: FYI: Thanks for #12! We'll do it, but we didn't have the time yet. If anyone can do this earlier, I'd of course appreciate that. Sorry.

This is bothersome. Any workarounds until a patch can be made?

Note: Additionally, when no element content is supplied, the <i> tag get filtered out completely.

<p>
    <i icon-name="menu"></i>
</p>

Becomes

<p></p>

In an attempt to work around, I tried to use an <svg>. But, it gets pushed outside the <a> it's in. Unrelated to the issue described above, but also annoying.

ravi.shankar → made their first commit to this issue’s fork.

Working on it.

Tried adding a failing test, to show the problem, but it succeeds...

@Grevil: testEmphasisWithoutFilterHtml is failing as expected, but we should be sure the result is what we expect. Could you please check the test result again? Could we perhaps explicitly compare the expected result so the test shows XX expected, actual result YY?

Thanks for picking this up for me!

Unfortunately, this is NOT the "expected" failure...

I'll have a look later.

Found the problem, I forgot to copy over all changes, as I am still struggling to set up a proper dev environment for core issues...

Now, comment #22 🐛 (iconfont icon) wrapped into with "Full HTML" Needs work should apply, and the test will succeed (but it is expected to fail).