- Issue created by @Anybody
- Status changed to Needs work
about 2 years ago 5:46pm 14 February 2023 - πΊπΈUnited States altagrade
Unfortunately, no time for writing tests. Mind becoming a co-maintainer?
- π©πͺGermany Anybody Porta Westfalica
Thank you, @AltaGrade, well if you'd like to, we can help. In that case also please add @Grevil as Co-Maintainer and I'll add these task to our companies TODO-list. Nice and helpful module, thanks :)
- πΊπΈUnited States altagrade
Thanks for agreeing to co-maintain this module. I've just give you all maintainer privileges, including the "Administer maintainers", so please go ahead and add @Grevil or whomever you deem necessary to add. We have developed and keep maintained this module mainly for our Backdrop customer project, and because of Backdrop and Drupal 7 similarities the changes made on Backdrop are easy to quickly pass to Drupal 7. However, unfortunately Drupal 9/10 version is many features behind. So we do hope you can move all the new features from either Backdrop or Drupal 7 to Drupal 9/10.
- π©πͺGermany Anybody Porta Westfalica
Thank you, I just created a separate issue for that: β¨ Implement Backdrop / Drupal 7 features for 2.x Active
I don't think we'll have the time short-term, but I'll add this to our list.
- Assigned to Grevil
- π©πͺGermany Anybody Porta Westfalica
@Grevil will have a look when we have the time! :)
- π©πͺGermany Anybody Porta Westfalica
Moved schema fixes to π Fix schema Active
- Issue was unassigned.
- π©πͺGermany Anybody Porta Westfalica
https://www.drupal.org/project/crowdsec β is an alternative now.
- π©πͺGermany lrwebks Porta Westfalica
What tests are left to do after the merge of π Colon identified as a spam character Active :
- Language Script validation
- Reject message changes
- Logging rejected submissions
- π©πͺGermany lrwebks Porta Westfalica
All three tests are added now, however the last one isn't fully working yet since I struggle to find the correct permission name for a user to access the DBLog page. @anybody are you in the know?
- π©πͺGermany Anybody Porta Westfalica
It's simply not a good idea to give anonymous users all these permissions. Would be better to use an authenticated user.
But let's stop here, enough time went in. I think this is a good one for @Grevil to review and teach you a bit in testing, if he finds possible improvements.Nice work :)
- π©πͺGermany lrwebks Porta Westfalica
Fixed the test, everything should be working now.