Optimise "seen" entity tracking when checking related usage

+++ b/src/Generate/GeneratePluginBase.php
@@ -66,7 +66,7 @@ abstract class GeneratePluginBase extends PluginBase implements GeneratePluginIn
-  public function entityAccess(PreviewSiteBuildInterface $build, ContentEntityInterface $entity, AccountInterface $account, EntityTypeManagerInterface $entityTypeManager): AccessResultInterface {
+  public function entityAccess(PreviewSiteBuildInterface $build, ContentEntityInterface $entity, AccountInterface $account): AccessResultInterface {

+++ b/src/Generate/GeneratePluginInterface.php
@@ -98,13 +98,11 @@ interface GeneratePluginInterface extends PreviewSitePluginInterface {
-   * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entityTypeManager
-   *   Entity type manager.
...
-  public function entityAccess(PreviewSiteBuildInterface $build, ContentEntityInterface $entity, AccountInterface $account, EntityTypeManagerInterface $entityTypeManager) : AccessResultInterface;
+  public function entityAccess(PreviewSiteBuildInterface $build, ContentEntityInterface $entity, AccountInterface $account) : AccessResultInterface;

Ah this we can't do, because its a public API and would be a BC break, let's leave it as is even though we won't use the argument.

Other than that, this looks great, heaps less astronaut architecture and dramatically less complex

@larowlan Thanks for the feedback. Ah, so you're saying that because it's a plugin folks could be calling it directly - I assume it's unlikely but valid. Probably one for a major release.

@larowlan Ok, I've restored those files and changed the calling signature back.

Thanks, fixed, I'll cut a new release with this and 🐛 Optimise "seen" entity tracking when checking related usage Fixed

🚀

Automatically closed - issue fixed for 2 weeks with no activity.