fjgarlin → credited mortim07 → .
LGTM. :)
@ananya.k I appreciate the patch, but it was also a question to the maintainers. :)
mortim07 → created an issue.
We have an issue where ::setRevisionCreationTime doesn't exist on the entity. To make this patch more robust we should be checking for the interface that implements ::setRevisionCreationTime - Drupal\Core\Entity\RevisionLogInterface.
This module isn't compatible with Drupal 10. It uses a hook which has been removed and replaced in Drupal 10. I'll raise a MR with a few fixes.
mortim07 → made their first commit to this issue’s fork.
mortim07 → made their first commit to this issue’s fork.
mortim07 → created an issue.
mortim07 → created an issue.
mortim07 → created an issue.
Thank you @huckwolf
@yovince For now I'd suggest keeping that plugin in your ecosystem.
@yovince A default value plugin to me implies that if a field is empty then it gets a default value. This differs from that in that it uses a regex to determine whether a value should apply or not - I'd say its more akin to the map plugin.
mortim07 → created an issue.
mortim07 → created an issue.
@kaszarobert Sorry for the delay in getting this done.
mortim07 → created an issue.
Closing as now implemented as https://www.drupal.org/project/data_pipelines_sftp →
@jibran We haven't added any tests for any other source resources. The test itself would be redundant because the only thing you could mock is getResource.
Following a discussion with @nterbogt I'll create a separate module for it because of its dependency on 'key'. We don't want to be bloating data pipelines out and forcing modules on people.
@jibran No you don't. It's all handled through listeners. There is no explicit definition for the field because its derived.
mortim07 → created an issue.
froboy → credited mortim07 → .
@kaszarobert Thanks for looking at the patch.
In regards to point 2. It only loads when the template media-entity-facebook is rendered and is_frame is FALSE.
I'll take a look at the language mapping and make the necessary changes.
jibran → credited mortim07 → .
Also, I think these are pipeline settings, not destination settings.
These are plugins not configuration.
I hope that confirmed it for you. :)
@jibran I assume to see if it fails?
@larowlan Can this be closed?
@larowlan Added test...finally. :)
No sweat! 🚀
mortim07 → made their first commit to this issue’s fork.
mortim07 → created an issue.
mortim07 → created an issue.
Re-roll.
Closed as part of https://git.drupalcode.org/project/nsw_point_api/-/merge_requests/3
Re-roll with changes introduced by https://www.drupal.org/project/nsw_point_api/issues/3385853 📌 Reduce dependency on jQuery Fixed
mortim07 → created an issue.
@jibran I'm going to add more detail as to how I identified it and why it's an issue.
mortim07 → created an issue.
It's in!
Looks good to me!