- Issue created by @mortim07
- last update
over 1 year ago 69 pass - Assigned to larowlan
- Status changed to Needs review
over 1 year ago 3:53am 29 August 2023 - π¨π¦Canada jibran Toronto, Canada
Let's get Lee's review on this one.
- π¦πΊAustralia mortim07
@jibran I'm going to add more detail as to how I identified it and why it's an issue.
- π¨π¦Canada jibran Toronto, Canada
This is not a correct statement in IS
> data_pipelines_data:pipeline_name:typeAs per the patch it should be
data_pipelines_data:pipeline_pluginId:type - π¨π¦Canada jibran Toronto, Canada
@larowlan any feedback on this one?
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Fix looks good to me, any way we can cover this with a test?
- last update
about 1 year ago 70 pass - π¨π¦Canada jibran Toronto, Canada
Can we please have a test only patch?
- last update
about 1 year ago 64 pass, 2 fail The last submitted patch, 12: 3383916-2-test.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to RTBC
about 1 year ago 10:47am 5 December 2023 -
jibran β
committed 4e91afb6 on 1.x authored by
mortim07 β
Issue #3383916 by mortim07, jibran, larowlan: Ensure typed data...
-
jibran β
committed 4e91afb6 on 1.x authored by
mortim07 β
- Status changed to Fixed
about 1 year ago 12:20am 18 December 2023 - π¨π¦Canada jibran Toronto, Canada
Thanks, committed and pushed to 1.x
-
jibran β
committed 5cbe79a4 on 1.x
Issue #3383916 by jibran: PHPCS fixes. Signed-off-by: Jibran Ijaz...
-
jibran β
committed 5cbe79a4 on 1.x
-
jibran β
committed b1ec4a76 on 1.x
Issue #3383916 by jibran: PHPCS fixes. Signed-off-by: Jibran Ijaz...
-
jibran β
committed b1ec4a76 on 1.x
Automatically closed - issue fixed for 2 weeks with no activity.