Extra space for given name causes double period for rendered citation

Created on 8 February 2023, over 2 years ago

Problem/Motivation

When the data is normalized if a middle name is missing a given name has an extra space at the end. It causes double period in citation for some CSL. For example APA

Steps to reproduce

Add any reference with a contributor. Set APA as a default CSL. Render it as a citation.

Expected: Davoodi, T., & Lombrozo, T. (2022). Explaining the existential ...
Actual: Davoodi, T. ., & Lombrozo, T. . (2022). Explaining the existential ...

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States xopoc

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @xopoc
  • πŸ‡ΊπŸ‡ΈUnited States xopoc
  • πŸ‡ΊπŸ‡ΈUnited States xopoc
  • πŸ‡ΊπŸ‡ΈUnited States xopoc
  • Status changed to Needs review about 2 months ago
  • πŸ‡¨πŸ‡¦Canada kpaxman

    I wasn't seeing this in the latest tag, but this seems to have been introduced with ✨ Deprecated packages in dependencies Fixed which has been merged into dev but not tagged in any release that I could see.

    This does fix the issue for me, but I'm not sure if the fix would affect anything else, so I'm setting this to needs review.

  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson
  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    I attempted to reproduce this problem on the 3.0.x-dev branch today and was unable to do so. Steps taken:

    1. Create a new Contributor at /admin/content/bibcite/contributor , entering a Middle Name and a Surname, but not a First Name.
    2. Create a Reference and associate it with this Contributor.
    3. Render this using the (default) APA style citation formatter provided by the module.
    4. Observe that there is no duplicative "double period" as described in the issue report.

    I also tried populating a whitespace character for the first name, and separately for the middle name.

    If this is still a problem, please provide additional steps to reproduce. Also, if it is a problem, it might more appropriately be addressed in https://github.com/ADCI/full-name-parser, which is a dependency of this module.

Production build 0.71.5 2024