- πΊπΈUnited States rbrandon
We have been using the patch from #29 and it seems to have been working well.
- First commit to issue fork.
- π¨π¦Canada adam-vessey PE, Canada
Err... I... might've accidentally done a thing? I didn't intend to create the issue fork/branch? I sas just trying to post a comment indicating that adding package entries for
citation-style-language/locales
(and[..]/styles
) should no longer be necessary, as they appear to have Packagist releases (as of March 2023?). @adam-vessey
We plan to update dependencies asap after beta3 release- πΊπΈUnited States rbrandon
@aardwolf great, we have had some issues lately with the seboettg library and would love some more eyes on this since the errors from academicpuma are also adding up and we need to get to PHP 8 ASAP.
@rbrandon
You can switch to latest version 3.0.x-dev and check bibcite on D10 and PHP 8.0+
Or you can try latest 2.0.x-dev for D8, D9
It would be helpful.- πΊπΈUnited States tlwatson
+1 to patch #29 as a solution; I am using this.
Note in addition to applying this patch, I needed to follow the README instructions of adding the citation-style-language/locales package to my composer repositories list, and then run `composer require citation-style-language/locales seboettg/citeproc-php`. (I also had to make sure that the 'intl' extension was installed in global PHP, in order to get a new enough version of seboettg/citeproc-php to resolve all the PHP 8.1 errors.)
Hopefully if/when this patch gets merged in, we shouldn't have to run `composer require`, as this ought to handle its own composer requirements... but it's necessary for now, so hopefully this comment helps someone else wanting to patch.
- π¨π¦Canada ebremner
I can confirm that patch 29 works on 9.5.10 and php 8.1
- πΊπΈUnited States rbrandon
@aardWolf we are still based of 2.x branch with the patch, and did find that we had a couple bugs fixed by using the most recent tag in seboettg/citeproc-php also we are contributing some small changes there.
One thing to make sure of that is a bug in the 2.x branch of bibcite is that the "given" name in the author data sent to citeproc needs to be trimmed of any whitespace so that it will not cause double abbreviations ie "N. ." instead of "N." when abbreviating "Name"
-
AardWolf β
committed d9976bb3 on 3.0.x
Issue #2992234 by rbrandon, xopoc, antongp, adam-vessey: Deprecated...
-
AardWolf β
committed d9976bb3 on 3.0.x
-
AardWolf β
authored b8426db9 on 2.0.x
Issue #2992234 by rbrandon, xopoc, antongp, adam-vessey: Deprecated...
-
AardWolf β
authored b8426db9 on 2.0.x
- Status changed to Fixed
over 1 year ago 8:43am 5 September 2023 We updated dependecies in both branches.
@rbrandon Also, I created new issue.
π Trim given name ActiveAutomatically closed - issue fixed for 2 weeks with no activity.