🇺🇸United States @rbrandon

Update of the patch to remove comment changes.

Patch to check the layout_builder_iframe_modal config before disabling the ajax submit handler in the form.

rbrandon → created an issue.

Similar to XB we have had to backport this to workaround some dependency issues and it is working well. We have several libraries that all depend on shared libraries. We were running into cases where the libraries were included in different aggregates and the dependencies were included in the minimal representative subset for both and ending up on the page twice.

Since the optimized aggregate urls don't track explicitly what other dependencies have been loaded like with ajax it would have required a lot of tinkering with weights and making duplicate libraries like with XB to get what the dependency sorting gives us out of the box.

Looks great, merged, thanks @scottatdrake

I updated merge request for 4.0.x branch with tests and addressed @kristen-pol comments.

rbrandon → made their first commit to this issue’s fork.

Think this is a good solution and looks good.

Duplicate of #2880512

Commited.

group_purl now has an active release confirmed to work with this module, closing this now that the two play nicely together.

This does not have enough info to troubleshoot.

Is this not how that Method is designed? It is called prefix, so I expect it to match any path prefixed with the modifier instead of matching the path exactly. I could also see where you would want to look at just a section of the path so that /foo/bar would just match on "foo".

finne this is no longer an issue in the current 8.x branch, the ContextHelper no longer passes the EntityTypeManager in construct, when I update the getStorage method to use dependency injection correctly I will use the interface.

rik-dev the current active branch is good for D9 and D10 so marking this fixed, please reopen if you have issues. seanb thanks for your work.

Marif4pk the current active branch is good for D9 and D10 so marking this fixed, please reopen if you have issues. seanb thanks for your work.

Committed

Thanks, Mike and Alberto, I appreciate your support.

Webflo, I will get the D10 version up here ASAP.

Thanks avpaderno, I did not contact them all so that would be helpful.

Link to main project, maybe it would help if project moderators are able to reach out also to yhahn and jmiccolis since it has been two weeks.

Link to project for ease: https://www.drupal.org/project/purl →

Still no reply from Contact from:

yhahn or jmiccolis, are you guys still active here?

We are currently running on D10 with our updated version. I will post that branch when approved or if it lingers more than a week further will find a way to get it to you if that works for your timeline. right now there are several patches applied off of an updated freelock branch so would be cleaner if I can get things consolidated.

rbrandon → created an issue.

Re-Rolled with new 2.0.x branch.

Only some small changes are required to stop using deprecated classes.

rbrandon → created an issue.

Greg,

Looks like this does not update the module to make use of the API key but instead lets the PubmedClient make use if a API key if called from another module. Looks like we needed to use an API key in order to get around a rate limit when this class was called importing a list of PMID's. Agree that adding this setting to the module to use by default might be a good idea.

Updated 2.x patch attached.

@aardWolf we are still based of 2.x branch with the patch, and did find that we had a couple bugs fixed by using the most recent tag in seboettg/citeproc-php also we are contributing some small changes there.

One thing to make sure of that is a bug in the 2.x branch of bibcite is that the "given" name in the author data sent to citeproc needs to be trimmed of any whitespace so that it will not cause double abbreviations ie "N. ." instead of "N." when abbreviating "Name"

This commit fixed a number of issue for us, but also created one when a redirect occurs when on a entity page. We need to carry through the master routematch if we are using it so that it holds the parameters for the entity page otherwise we will get NULL values in return. The attached patch fixes just that issue although I would like to completely rewrite this function.

Same issue, @minkahb did you find the issue before I dig through the code?

@aardwolf great, we have had some issues lately with the seboettg library and would love some more eyes on this since the errors from academicpuma are also adding up and we need to get to PHP 8 ASAP.

We have been using the patch from #29 and it seems to have been working well.